Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding doctests in stock_span_problem.py #10540

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Adding doctests in stock_span_problem.py #10540

wants to merge 15 commits into from

Conversation

AasheeshLikePanner
Copy link
Contributor

@AasheeshLikePanner AasheeshLikePanner commented Oct 15, 2023 •
edited
Loading

Describe your change:

Adding doctests in stock_span_problem.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    Improve our test coverage #9943

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 15, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this pull request Oct 15, 2023
Open
cclauss
cclauss reviewed Oct 15, 2023
View reviewed changes
data_structures/stacks/stock_span_problem.py Outdated
Calculate the span values for a given list of stock prices.
Args:
price (list): List of stock prices.
s (list): List to store the span values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you forcing to caller to allocate this memory? Why not do this in the function?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AasheeshLikePanner didn't write the code in that way. The code was already like that back when it was first contributed to the repo. The code had the caller allocate the memory because it was directly copied (and thus plagiarized) from the GeeksForGeeks article you linked a few hours ago.

@cclauss cclauss self-assigned this Oct 15, 2023
cclauss
cclauss requested changes Oct 15, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10540 (comment)

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR labels Oct 16, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 16, 2023
@AasheeshLikePanner
Update stock_span_problem.py
3ba3cf7
@AasheeshLikePanner
Merge remote-tracking branch 'origin/StockAndSpan_Doctests' into Stoc…
ec23923 
…kAndSpan_Doctests

# Conflicts:
#	data_structures/stacks/stock_span_problem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 left review comments

@cclauss cclauss Awaiting requested review from cclauss

Requested changes must be addressed to merge this pull request.

Assignees

@cclauss cclauss

Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AasheeshLikePanner @cclauss @tianyizheng02