Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added postfix-prefix conversion #10474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added postfix-prefix conversion #10474

wants to merge 2 commits into from

Conversation

arnavjagia
Copy link

@arnavjagia arnavjagia commented Oct 14, 2023 •
edited
Loading

Describe your change:

Added postfix-prefix conversion

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 14, 2023
tianyizheng02
tianyizheng02 requested changes Oct 15, 2023
View reviewed changes
data_structures/stacks/postfix_to_prefix_conversion.py
Comment on lines +19 to +20
Raises:
IndexError: If the expression is invalid or contains an invalid operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you add checks in your code for these cases rather than relying on Stack's IndexError? That way we can have more useful error messages for this algorithm.
  2. Could you add a doctest that tests an invalid expression and a doctest that tests an invalid operator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnavjagia @tianyizheng02