Skip to content

Commit

Permalink
Always run benchmark comparison
Browse files Browse the repository at this point in the history
If benchmark failed consider it design_failure_flag not flow_failure_flag
  • Loading branch information
kareefardi committed Dec 19, 2023
1 parent aae172e commit 89ce44e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/scripts/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ def cat(x):
)
print("Created ./reproducible.tar.gz.")

if run_return_code != 0:
print("Run failed")
raise run_exception

difference_reports = glob.glob(os.path.join(results_folder, f"{test_name}*.rpt"))
if len(difference_reports):
print("Verbose differences within the benchmark:")
Expand All @@ -125,4 +121,8 @@ def cat(x):
print("Testing the design has failed.")
exit(-1)

if run_return_code != 0:
print("Run failed")
raise run_exception

print("Done.")
2 changes: 1 addition & 1 deletion run_designs.py
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ def run_design(designs_queue):
design,
f"Failed to compare with benchmark: {error_msg}",
)
flow_failure_flag = True
design_failure_flag = True

if delete:
try:
Expand Down

0 comments on commit 89ce44e

Please sign in to comment.