Skip to content

test(#69): build regression test suite - #126

Merged
Kalchaqui merged 7 commits into
Thalos-Infrastructure:mainfrom
Cbiux:test/issue-69-regression-suite
Jul 30, 2026
Merged

test(#69): build regression test suite#126
Kalchaqui merged 7 commits into
Thalos-Infrastructure:mainfrom
Cbiux:test/issue-69-regression-suite

Conversation

@Cbiux

@Cbiux Cbiux commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a dedicated *.regression.spec.ts suite covering webhook status sync, validation, status transitions, activity logging, and API edge cases — each test cites its originating issue/PR.
  • Documents the policy that bug-fix PRs are not done without a regression test (CONTRIBUTING.md + docs/integration-tests.md index).
  • Specs are independent (mocked Supabase/TW) and run via existing pnpm test / CI (testRegex: .*\.spec\.ts$).

Closes #69

Regression index (test → issue/PR)

Spec Guards Issue / PR
webhook-status-mapping.regression.spec.ts escrow.releasedcompleted #52 / PR #54
dispute-percentages.regression.spec.ts percentages must sum to 100 #12 / PR #49
stellar-address.regression.spec.ts invalid Stellar address rejected #27
status-transitions.regression.spec.ts illegal transitions blocked #59 / #67 · PR #110 / #76
agreement-activity.regression.spec.ts dispute/status → agreement_activity + states #58 / #61 · PR #100 / #104
api-edge-cases.regression.spec.ts invalid JWT / 404 / unauthorized by-wallet #15 / #51 · PR #57

Policy

Test plan

  • pnpm exec jest regression --runInBand — 6 suites / 12 tests green
  • Specs pass in reverse file order (independence)
  • pnpm exec jest --runInBand — full suite 26 / 596 green (local)
  • Confirm CI Test job green on this PR

Local CI-equivalent output (excerpt)

Test Suites: 6 passed, 6 total
Tests:       12 passed, 12 total
Ran all test suites matching regression.

Test Suites: 26 passed, 26 total
Tests:       596 passed, 596 total
Ran all test suites.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Cbiux is attempting to deploy a commit to the ManuelJG's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Kalchaqui

Copy link
Copy Markdown
Collaborator

Review — request changes (CI Format/Lint)

Thanks @Cbiux — solid work on #69. The regression convention, docs/policy, and issue/PR-traced specs look good. Scope is right.

Blocker before merge

CI is currently red:

  • Format fails (prettier --check)
  • Lint fails on the new *.regression.spec.ts files (and a few annotations in related specs)

Please run locally and push:

pnpm run format
pnpm run lint
pnpm exec jest regression --runInBand

Once Format + Lint + Test are green on this PR, happy to merge. (Vercel deploy authorization is unrelated and not a blocker.)

Non-blocking nits

  • Fix the CONTRIBUTING path typo if still present (src/<feature>/*.regression.spec.ts).
  • Optional later: shared buildDb helper across regression files.

Looking forward to the CI-green follow-up — nice foundation for the regression policy.

@Cbiux
Cbiux force-pushed the test/issue-69-regression-suite branch from dbaf71f to c59d6ca Compare July 30, 2026 04:29
@Cbiux

Cbiux commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Pushed a CI follow-up: chore: fix regression suite format and lint for CI

Local verification (same commands as CI):

  • pnpm run format:check — green
  • pnpm run lint:check — 0 errors (warnings only, pre-existing / non-blocking)
  • pnpm exec jest regression --runInBand — 6 suites / 12 tests green

Also updated CONTRIBUTING naming to src/<feature>/*.regression.spec.ts.

@Kalchaqui

Copy link
Copy Markdown
Collaborator

Re-review (c59d6ca) — LGTM

Thanks @Cbiux — the Format/Lint follow-up addresses the previous blocker.

Verified locally on this tip

  • pnpm run format:check — green
  • pnpm run lint:check0 errors (warnings only, pre-existing)
  • pnpm exec jest regression --runInBand6 suites / 12 tests green
  • CONTRIBUTING naming updated to src/<feature>/*.regression.spec.ts
  • No merge conflicts with current main

Verdict

LGTM — mergeable. Nice foundation for the #69 regression policy.

Maintainer: fine to merge when ready.

@Kalchaqui

Copy link
Copy Markdown
Collaborator

Merging

Format/Lint blocker cleared — verified locally and merging now. Thanks @Cbiux for the #69 regression suite + policy.

@Kalchaqui
Kalchaqui merged commit 4874817 into Thalos-Infrastructure:main Jul 30, 2026
3 of 7 checks passed
@grantfox-oss grantfox-oss Bot mentioned this pull request Jul 30, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Regression Test Suite

2 participants