fix: handle negative mouse coordinates#5688
fix: handle negative mouse coordinates#5688TomJGooding wants to merge 1 commit intoTextualize:mainfrom
Conversation
It is possible that terminals will report negative mouse coordinates when using SGR-Pixels (1016). While this arguably violates the standard for CSI sequences (see Textualize#5559), perhaps Textual should be more resilient to handle these sequences.
|
I'm all for a pragmatic approach. It's certainly better than breaking. But there are a couple of issues here. What happens when a negative coordinate arrives? Presumably Textual will send that negative coordinate to the app. But then we have different behavior compared to more compliant terminals. I think we should ignore negative coordinates to maintain consistency. I'd also like to tighten up the regexes a bit. My regex-fu isn't great, but if I have read the code correctly, it will allow nonsense strings like "12-1234-234-234-23". Which isn't likely to occur, but I'd feel better about it if the hyphen could occur in the first position only. |
|
Agreed, I'm very wary to change the regex which is why I left this in draft! Should the negative coordinates just be ignored? I think clicking and dragging outside the terminal window still reports mouse events even in 'compliant' terminals, but just aren't negative. Perhaps I've just misunderstood what you mean. |
|
Apparently superseded by #5926 |
2 participants
It is possible that terminals will report negative mouse coordinates when using SGR-Pixels (1016). While this arguably violates the standard for CSI sequences (see #5559), perhaps Textual should be more resilient to handle these sequences.
Please review the following checklist.