library - ZK - No more complaints about missing version file. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion here: #254 (comment)
Providing .version.yaml should not be obligatory. There should be a silent error when .version.yaml is missing.
Honestly, I am confused by the code there. Calling the loop from a thread in sync method is 🤯 Why cannot we just read the file?
@mithunbharadwaj - these changes will probably affect asab-library also...
@mithunbharadwaj - I can see pull request also about .disabled file - remember, please, there are also use cases for asab.library where .disabeld file does not exist.
Aren't these things (versions, disabled) too specific for ASAB as a framework...?