Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs in asab.library #254

Closed
6 tasks done
ateska opened this issue Jul 5, 2022 · 4 comments
Closed
6 tasks done

TODOs in asab.library #254

ateska opened this issue Jul 5, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ateska
Copy link
Contributor

ateska commented Jul 5, 2022

There are remainders from #239

@ateska ateska added the enhancement New feature or request label Jul 5, 2022
@ateska ateska added this to the v22.06-rc1 milestone Jul 5, 2022
@ateska ateska linked a pull request Jul 6, 2022 that will close this issue
@eliska-n
Copy link
Collaborator

eliska-n commented Jul 18, 2022

Maybe my user experience will be useful:

L.warning("File `/.version.yaml` likely doesn't exists.")

Yes, theres's no version file in my library. Could asab.library make one for me? It would make me very happy. 🐷 And it even periodically tries to read the non-existing version file.

This is ok?
image

@ateska
Copy link
Contributor Author

ateska commented Jul 18, 2022

Maybe my user experience will be useful:

L.warning("File `/.version.yaml` likely doesn't exists.")

Yes, theres's no version file in my library. Could asab.library make one for me? It would make me very happy. 🐷 And it even periodically tries to read the non-existing version file.
This is ok? image

This is intentionally a silent error - there is no degradation of the READ functionality, if the file is missing
ASAB Library will create .version.yaml file.
Reading non-existing version file periodically is acceptable.

@eliska-n
Copy link
Collaborator

I can add .version.yaml into my library or get a bunch of NoNode errors every minute. It is not very silent. Quite hard to accept.

@ateska
Copy link
Contributor Author

ateska commented Jul 21, 2022

I can add .version.yaml into my library or get a bunch of NoNode errors every minute. It is not very silent. Quite hard to accept.

Then the error must be silent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants