Skip to content

feat: set json content-type on share response #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoran995 merged 1 commit into from
May 21, 2026
Merged

feat: set json content-type on share response #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/controllers/share.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export default function (_hostName, port, options) {
}
try {
const content = await resolver(serviceOptions, id);
res.send(content);
res.set("Content-Type", "application/json").send(content);
} catch (reason) {
console.warn(JSON.stringify(reason.response, null, 2));
res
Expand Down
4 changes: 2 additions & 2 deletions spec/share-s3.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe("Share Module (e2e) - S3", () => {

await supertestReq(app)
.get("/share/s3-aqJr26G16vOvgbBGgrfzSYLIcy")
.expect(200, Buffer.from(JSON.stringify({ data: "test content" })));
.expect(200, { data: "test content" });
});

it('returns correct url in response when "newShareUrlPrefix" is empty string', async () => {
Expand Down Expand Up @@ -104,7 +104,7 @@ describe("Share Module (e2e) - S3", () => {

await supertestReq(app)
.get("/share/hBp74ADLrPU6flu0qu07Kyi1FM0")
.expect(200, Buffer.from(JSON.stringify({ data: "test content empty" })));
.expect(200, { data: "test content empty" });
});

it("should return 404 for non-existent share", async () => {
Expand Down