issue 956 - exclude orphaned stories (#971)

* issue 956 - exclude orphaned stories from both dashboard and api controllers

* issue 956 - exclude orphaned stories from home controller for map

* issue 956 - undoing removal of orphaned stories in StoriesPage

* issue 956 - unit test

* issue 956 - unit test

* issue 956 - unit test - updating comments and variable names for clarity

* changes per comments

* Remove unused let

---------

Co-authored-by: Laura Mosher <[email protected]>

rails/app/controllers/home_controller.rb

@@ -24,6 +24,9 @@ def create
   end
 
   helper_method def stories
-    policy_scope(current_community.stories)
+    community_stories = policy_scope(current_community.stories)
+    community_stories = community_stories.joins(:speakers).distinct
+    community_stories = community_stories.joins(:places).distinct
+    community_stories
   end
 end

rails/spec/requests/api/public_stories_spec.rb

@@ -132,7 +132,6 @@
 
       get "/api/communities/cool_community/stories"
 
-
       expect(json_meta["total"]).to eq(1)
       expect(json_response["stories"].map { |s| s["id"] }).to contain_exactly(story_1.id)
     end

rails/spec/requests/home_request_spec.rb

@@ -20,5 +20,47 @@
         expect(response).to redirect_to("/users/sign_in")
       end
     end
+
+    context "orphaned stories" do
+      let(:community) { FactoryBot.create(:community, name: "Orphaned Community") }
+      let(:user) { FactoryBot.create(:user, community: community) }
+      let!(:place_1) { create(:place, community: community, region: "test place 1") }
+      let!(:place_2) { create(:place, community: community, region: "test place 2") }
+      let!(:speaker_1) { create(:speaker, community: community) }
+      let!(:speaker_2) { create(:speaker, community: community) }
+      let!(:story_1) do
+        create(
+          :story,
+          community: community,
+          places: [place_1],
+          speakers: [speaker_1],
+          desc: "This story should not be visible because it has no speaker",
+          permission_level: :anonymous
+        )
+      end
+      let!(:story_2) do
+        create(
+          :story,
+          community: community,
+          places: [place_2],
+          speakers: [speaker_2],
+          desc: "This story should not be visible because it has no place",
+          permission_level: :anonymous
+        )
+      end
+
+      before do
+        login_as user
+      end
+
+      it "excludes stories with no speaker and/or place" do
+        speaker_1.destroy
+        place_2.destroy
+        get "/home"
+
+        expect(response.body).not_to include('This story should not be visible because it has no speaker')
+        expect(response.body).not_to include('This story should not be visible because it has no place')
+      end
+    end
   end
 end