Skip to content

Conversation

Huayeaaa
Copy link
Collaborator

@Huayeaaa Huayeaaa commented Sep 11, 2024

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@Huayeaaa Huayeaaa added the pr/reviewable 可被 review 的 PR label Sep 11, 2024
@Huayeaaa Huayeaaa requested a review from wyyalt September 11, 2024 03:19
@Huayeaaa Huayeaaa self-assigned this Sep 11, 2024
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2433 branch from bdd5880 to 36d9fff Compare September 13, 2024 08:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.4.7-dev@5030f1e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
apps/node_man/iam_provider.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             v2.4.7-dev    #2436   +/-   ##
=============================================
  Coverage              ?   75.18%           
=============================================
  Files                 ?      405           
  Lines                 ?    29151           
  Branches              ?        0           
=============================================
  Hits                  ?    21918           
  Misses                ?     7233           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2433 branch 2 times, most recently from c11c6ba to a1fc6a3 Compare September 14, 2024 08:13
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2433 branch from a1fc6a3 to c2c2f07 Compare October 29, 2024 14:10
@Huayeaaa Huayeaaa changed the base branch from v2.4.7-dev to v2.4.8-dev October 29, 2024 14:11
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2433 branch from c2c2f07 to b65b32c Compare December 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants