feat：用户个人视角权限管理优化 #11138 #11365

useryuyu · 2025-01-02T09:16:22Z

# Reviewed, transaction id: 28286

lockiechen · 2025-01-02T11:30:12Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+              :resource-name="item.resourceTypeName"
+              :loading="item.tableLoading"
+              :group-name="item.resourceTypeName"
+              :type="'AUTHORIZATION'"


没必要多余写个变量，直接type="AUTHORIZATION"就行

lockiechen · 2025-01-02T11:31:00Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+              <i :class="{
+                'manage-icon manage-icon-down-shape': item.activeFlag,
+                'manage-icon manage-icon-right-shape': !item.activeFlag,
+                'shape-icon': true,


这个可以把manage-icon放到下面

lockiechen · 2025-01-02T11:33:18Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+          <span
+            :class="{
+              'resource-name': true,
+              'hover-link': ['codecc_task', 'pipeline', 'pipeline_group'].includes(row.resourceType)


['codecc_task', 'pipeline', 'pipeline_group'].includes(row.resourceType)

你下面已经有个computed了这个可以在处理数据的时候就用个字段存起来的

lockiechen · 2025-01-02T11:33:54Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+const refTable = ref(null);
+const resourceType = computed(() => props.resourceType);
+const projectId = computed(() => route.params?.projectCode || route.query?.projectCode);
+const tableList = computed(() => props.data);


这个没有意义，不过你可以data里面加一些字段方便上面的template用

这里怎么还是没改，你直接用Props.data就行

lockiechen · 2025-01-02T11:34:13Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+const route = useRoute();
+const { t } = useI18n();
+const refTable = ref(null);
+const resourceType = computed(() => props.resourceType);


这个直接用props就行，没必要再弄个computed

lockiechen · 2025-01-02T11:34:50Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+ * 跳转页面
+ */
+function handleToResourcePage (row) {
+  if (!(['codecc_task', 'pipeline', 'pipeline_group'].includes(row.resourceType))) return


这里这个判断还重复了

lockiechen · 2025-01-02T11:35:38Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+    case 'pipeline_group':
+      window.open(`${location.origin}/console/pipeline/${projectId.value}/list/listAuth/${row.resourceCode}/${row.resourceName}?groupId=${row.groupId}`)
+      return
+    case 'codecc_task':


像这几个很多地方用到的，用枚举来维护，不要到处写的都是'codecc_task', 'pipeline', 'pipeline_group'

lockiechen · 2025-01-02T11:36:31Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+const { t } = useI18n();
+const detailGroupTable = userDetailGroupTable();
+const projectTable = computed(() => props.sourceList.filter(item => item.type === "AUTHORIZATION"));
+const sourceTable= computed(() => props.sourceList.filter(item => item.type === "GROUP"));


我看你下面HandoverType有这个枚举，怎么不用？

# Reviewed, transaction id: 28321

lockiechen · 2025-01-03T02:42:16Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+          <span
+            :class="{
+              'resource-name': true,
+              'hover-link': LINKABLE_RESOURCE_TYPES.includes(row.resourceType)


我说的是这个表达式，可以直接放到下面的computed提前声明

lockiechen · 2025-01-03T02:42:30Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+const refTable = ref(null);
+const resourceType = computed(() => props.resourceType);
+const projectId = computed(() => route.params?.projectCode || route.query?.projectCode);
+const tableList = computed(() => props.data);


lockiechen · 2025-01-03T02:42:46Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+ * 跳转页面
+ */
+function handleToResourcePage (row) {
+  if (!LINKABLE_RESOURCE_TYPES.includes(row.resourceType)) return


这样就没必要在这里再计算一次了

# Reviewed, transaction id: 28332

# Reviewed, transaction id: 28334

# Reviewed, transaction id: 28335

lockiechen · 2025-01-03T03:33:44Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+              :resource-name="item.resourceTypeName"
+              :loading="item.tableLoading"
+              :group-name="item.resourceTypeName"
+              type="AUTHORIZATION"


这个枚举已经有了，直接用

lockiechen · 2025-01-03T03:33:58Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+      >
+        <bk-collapse-panel
+          v-model="item.activeFlag"
+          :item-click="(type) => collapseClick(type, 'GROUP')"


这里也是

lockiechen · 2025-01-03T03:34:06Z

...-manage/src/components/user-group/components/children/permission-manage/detail-group-tab.vue

+              :resource-name="item.resourceTypeName"
+              :loading="item.tableLoading"
+              :group-name="item.resourceTypeName"
+              type="GROUP"


lockiechen · 2025-01-03T03:34:51Z

...-manage/src/components/user-group/components/children/permission-manage/detail-tab-table.vue

+const refTable = ref(null);
+const resourceType = computed(() => props.resourceType);
+const projectId = computed(() => route.params?.projectCode || route.query?.projectCode);
+const tableList = computed(() => props.data);


这里怎么还是没改，你直接用Props.data就行

lockiechen · 2025-01-03T03:35:22Z

src/frontend/devops-permission/src/components/permission-manage/detail-group-tab.vue

+  return {
+    'permission-icon permission-icon-down-shape': activeFlag,
+    'permission-icon permission-icon-right-shape': !activeFlag,
+    'shape-icon': true


这里也是permission-icon 放下面去

# Reviewed, transaction id: 28346

# Reviewed, transaction id: 28347

lockiechen · 2025-01-03T06:21:29Z

src/frontend/devops-permission/src/components/permission-manage/detail-group-tab.vue

@@ -47,7 +43,7 @@
              :resource-name="item.resourceTypeName"
              :loading="item.tableLoading"
              :group-name="item.resourceTypeName"
-              :type="'AUTHORIZATION'"
+              type="AUTHORIZATION"


lockiechen · 2025-01-03T06:21:38Z

src/frontend/devops-permission/src/components/permission-manage/detail-group-tab.vue

@@ -97,7 +89,7 @@
              :resource-name="item.resourceTypeName"
              :loading="item.tableLoading"
              :group-name="item.resourceTypeName"
-              :type="'GROUP'"
+              type="GROUP"


.../devops-manage/src/components/user-group/components/children/permission-manage/tab-table.vue

# Reviewed, transaction id: 28358

lockiechen · 2025-01-03T06:44:19Z

src/frontend/devops-manage/src/store/userDetailGroupTable.ts

+
+      if (currentRequestId === requestId) {
+        detailSourceList.value.forEach(item => {
+          if (authorizationList && item === authorizationItem) {


你这里authorizationList其实是个object，这种命名是有歧义的，如果是返回的空对象，这个if还是有可能可以进去的，这个会导致item.tableData是undefined，这个异常你有处理不？

# Reviewed, transaction id: 28363

# Reviewed, transaction id: 28370

# Reviewed, transaction id: 28382

# Reviewed, transaction id: 28397

feat：用户个人视角权限管理优化 TencentBlueKing#11138

af2cf42

# Reviewed, transaction id: 28286

useryuyu requested review from lockiechen, terlinhe and zhanxu33 as code owners January 2, 2025 09:16

lockiechen reviewed Jan 2, 2025

View reviewed changes

feat：用户个人视角权限管理优化 TencentBlueKing#11138

2291dd1

# Reviewed, transaction id: 28321

lockiechen reviewed Jan 3, 2025

View reviewed changes

useryuyu added 3 commits January 3, 2025 10:54

feat：用户个人视角权限管理优化 TencentBlueKing#11138

839cc32

# Reviewed, transaction id: 28332

feat：用户个人视角权限管理优化 TencentBlueKing#11138

9fd2684

# Reviewed, transaction id: 28334

feat：用户个人视角权限管理优化 TencentBlueKing#11138

a50c92a

# Reviewed, transaction id: 28335

lockiechen reviewed Jan 3, 2025

View reviewed changes

useryuyu added 2 commits January 3, 2025 13:24

feat：用户个人视角权限管理优化 TencentBlueKing#11138

bf2724a

# Reviewed, transaction id: 28346

feat：用户个人视角权限管理优化 TencentBlueKing#11138

8c30dd8

# Reviewed, transaction id: 28347

lockiechen reviewed Jan 3, 2025

View reviewed changes

feat：用户个人视角权限管理优化 TencentBlueKing#11138

9f3ee62

# Reviewed, transaction id: 28358

lockiechen reviewed Jan 3, 2025

View reviewed changes

useryuyu added 4 commits January 3, 2025 14:45

feat：用户个人视角权限管理优化 TencentBlueKing#11138

5d2cd75

# Reviewed, transaction id: 28363

feat：用户个人视角权限管理优化 TencentBlueKing#11138

4c15673

# Reviewed, transaction id: 28370

feat：用户个人视角权限管理优化 TencentBlueKing#11138

637d1dc

# Reviewed, transaction id: 28382

feat：用户个人视角权限管理优化 TencentBlueKing#11138

f648a23

# Reviewed, transaction id: 28397

lockiechen approved these changes Jan 3, 2025

View reviewed changes

useryuyu closed this Jan 3, 2025

useryuyu reopened this Jan 3, 2025

bkci-bot merged commit d37c587 into TencentBlueKing:master Jan 6, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat：用户个人视角权限管理优化 #11138 #11365

feat：用户个人视角权限管理优化 #11138 #11365

useryuyu commented Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 2, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

lockiechen Jan 3, 2025

feat：用户个人视角 权限管理优化 #11138 #11365

feat：用户个人视角 权限管理优化 #11138 #11365

Conversation

useryuyu commented Jan 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat：用户个人视角权限管理优化 #11138 #11365

feat：用户个人视角权限管理优化 #11138 #11365