Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple api add CVPixelBuffer、CMSampleBuffer、UIImage convenient #3800

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Apple api add CVPixelBuffer、CMSampleBuffer、UIImage convenient #3800

wants to merge 49 commits into from

Conversation

DaChengTechnology
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (9376ba7) to head (38bdb98).
Report is 722 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3800      +/-   ##
==========================================
+ Coverage   92.98%   93.72%   +0.73%     
==========================================
  Files         709      728      +19     
  Lines      176425   176889     +464     
==========================================
+ Hits       164049   165781    +1732     
+ Misses      12376    11108    -1268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihui
Copy link
Member

nihui commented May 19, 2022

todo:
apply coding style for mm sources
wrap platform specific features with NCNN_PLATFORM_API macro
add some tests

@DaChengTechnology
Copy link
Contributor Author

DaChengTechnology commented May 19, 2022 •
edited
Loading

How do you passed the < build shared >check?

DaChengTechnology
DaChengTechnology commented May 25, 2022
View reviewed changes
Copy link
Contributor Author

@DaChengTechnology DaChengTechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix issue 3829

@tencent-adm
Copy link
Member

tencent-adm commented May 31, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nihui
❌ DaChengTechnology
You have signed the CLA already but the status is still pending? Let us recheck it.

DaChengTechnology
DaChengTechnology commented Jun 6, 2022
View reviewed changes
src/mat_pixel_apple.mm
CVPixelBufferUnlockBaseAddress(pixelbuffer, kCVPixelBufferLock_ReadOnly);

int type_from = PIXEL_RGB;
int type = type_to == type_from ? type_from : (type_from | (type_to << PIXEL_CONVERT_SHIFT));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我就猜到你要这么改 MacOS过不了啊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihui

DaChengTechnology
DaChengTechnology commented Jun 6, 2022
View reviewed changes
Copy link
Contributor Author

@DaChengTechnology DaChengTechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intel Mac not surpported

from_pixels

function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihui nihui nihui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaChengTechnology @codecov-commenter @nihui @tencent-adm