Skip to content

fix: let request-help return structured timeout outcomes - #154

Open
giattijunior wants to merge 1 commit into
Tencent:mainfrom
giattijunior:fix/request-help-timeout-grace
Open

fix: let request-help return structured timeout outcomes#154
giattijunior wants to merge 1 commit into
Tencent:mainfrom
giattijunior:fix/request-help-timeout-grace

Conversation

@giattijunior

Copy link
Copy Markdown

Problem

request-help passes its user-facing timeout to the generic per-session queue. When no human action occurs, the extension's timer and the daemon queue timeout race at the same deadline; the queue can return a generic RPC timeout before the extension returns the documented timed_out result.

Fix

Give only tool.request_help one second of daemon-side response grace. The original timeout_ms remains unchanged in the extension-facing params, so the user-visible deadline is preserved. Other tools keep their existing timeout behavior.

Validation

  • git diff --check passes.
  • Reproduced on CLI 0.1.11: bsk request-help --timeout 5s returned generic RPC timeout.
  • Confirmed the structured completion path with valid completion-criteria.
  • Cargo tests could not be run in the validation environment because Rust/Cargo is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant