fix: let request-help return structured timeout outcomes - #154
Open
giattijunior wants to merge 1 commit into
Open
fix: let request-help return structured timeout outcomes#154giattijunior wants to merge 1 commit into
giattijunior wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
request-helppasses its user-facing timeout to the generic per-session queue. When no human action occurs, the extension's timer and the daemon queue timeout race at the same deadline; the queue can return a generic RPC timeout before the extension returns the documentedtimed_outresult.Fix
Give only
tool.request_helpone second of daemon-side response grace. The originaltimeout_msremains unchanged in the extension-facing params, so the user-visible deadline is preserved. Other tools keep their existing timeout behavior.Validation
git diff --checkpasses.0.1.11:bsk request-help --timeout 5sreturned generic RPC timeout.completion-criteria.