Fix Face ID reference prefix with LTX keyframe conditioning - #19
Open
jjdejong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a shape mismatch when
LTX Reference Enable/ Best Face ID reference-token injection is combined with LTX guide/keyframe conditioning, including looping sampler workflows.Reproduction
The sampler fails in
LTXVModel._process_output()with an error such as:For a 31-frame, 17x17 latent tile, LTX keyframe filtering leaves 8,959 target tokens. The Face ID patch then prepends one 17x17 reference frame (289 tokens), producing 9,248 output tokens. The base LTX output path still applies the original 8,959-position
grid_mask.Root cause
LTXVModel._process_output()reconstructs guide/keyframe outputs before the existing instance-level unpatchify wrapper runs. The wrapper therefore removes the Face ID prefix too late.Fix
Patch
LTXVModel._process_output()so it removes the pending Face ID reference prefix from both the model output and video timestep tensor before LTX performs keyframe reconstruction. The pending length is cleared so the later unpatchify wrapper does not strip the prefix twice.No node API, workflow format, or default behavior is changed for graphs that do not inject a reference prefix.
Validation
git diff --checkpassed.