chore(infra): pin Rust base, add Helm probes, drop obsolete compose version#195
Merged
Conversation
…lete compose version keys
- crates/{api,indexer}/Dockerfile: pin FROM rust:1-slim -> rust:1.83-slim
for reproducible builds (edition 2021, all locked deps build on 1.83).
- helm: add liveness/readiness probes to the grpc-api (tcpSocket 5000),
nginx (tcpSocket 80), and indexer (httpGet /metrics on the Prometheus
port 9090, now exposed) deployments — only go-api had probes before.
- docker/docker-compose{,.dev}.yml: remove the obsolete top-level
version: key (Compose v2 ignores it and warns; dev's was malformed).
1.83 was too old to parse the edition-2024 manifest of the idna_adapter dependency (needs rustc >= 1.85); 1.88 matches the recent stable the floating rust:1 tag was resolving to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the hardening sweep (item D: build reproducibility & config hygiene).
FROM rust:1-slim->rust:1.83-slimin both Rust images for reproducible builds (floating major tag silently changed the toolchain). Verified by the Docker build + E2E jobs.tcpSocket: 5000tcpSocket: 80httpGet /metricson the Prometheus port 9090 (now exposed as a named port)version:key fromdocker-compose.ymlanddocker-compose.dev.yml(Compose v2 ignores it and warns; the dev file's was malformed across two lines).