test(ci): run SDK test suites that were never executed#192
Merged
Conversation
CI only typechecked sdk/typescript and never ran any SDK test suite, so these suites were false-green (or silently rotted): - sdk/typescript: CI ran only `npm run lint` (tsc). Add `npm test` (vitest). graphql.test.ts imported msw but msw was never declared — add it as a devDependency. (29 tests now run) - sdk/go: add a job running `go test -race ./...`. (passes) - sdk/python: add a job; declare a [dev] extra (pytest, pytest-asyncio) and fix a test-side mock in test_async_client that made websockets.connect return a coroutine instead of an async context manager. (19 tests now run) - sdk/react: add a job running the vitest suite. (12 tests)
- sdk/typescript: regenerate package-lock.json cleanly; the incremental msw install left it internally inconsistent (@emnapi version drift) so npm ci rejected it on the Linux runner. - sdk-react: build the TypeScript SDK before installing react. react depends on it via file:../typescript, which resolves to its gitignored dist/ — absent in a clean checkout, so the import failed only in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide hardening sweep (item A: false-green tests).
CI only typechecked
sdk/typescriptand ran no SDK test suite at all. Every SDK's tests were committed but never executed — false green. This wires them in and fixes the rot that surfaced:npm test(vitest).graphql.test.tsimportedmswwhich was never declared — added as devDependency. 29 tests now run.go test -race ./...job. Passes as-is.[dev]extra (pytest, pytest-asyncio) and fixed a test-side mock intest_async_clientthat madewebsockets.connectreturn a coroutine instead of an async context manager. 19 tests now run.All four verified green locally before wiring.