meson: Clean up python module check

[jtojnar]

Follow up 3a1ce69#r43789669

[Kaffeine]

Please retarget the PR to branch telepathy-idle-0.2 so this can go for telepathy-idle-0.2.3 release (I have no idea if we'll ever have 0.3 release).

By default, the timeout is 30 seconds and only less than half of twisted tests manage to get run.

Hm. ninja test does not fail for me: I think I have all tests passed in about 15 seconds.
Yet it won't hurt to increase the timeout.

About the license:

• The project is under LGPLv2.1. If you want to use a different license for the meson files, then please add license headers (similar to https://gitlab.freedesktop.org/mesa/mesa/-/blob/master/meson.build#L1 but with the license of your choice). Add your name to the first line (something like Copyright (C) 2020 Jan Tojnar seems to be correct).

• Sailfish OS has issues with (L)GPLv3: some Jolla partners do business for the corporate market. It is typical for them (the partners) to sell devices with locked-down firmware and it contradicts "anti-tivoization" statements from v3 licenses. Jolla has to avoid all (L)GPLv3 code.

I am not a lawyer but I think it is quite possible that (L)GPLv3 code in the project build module will make SFOS never update to the new version.
OTOH Sailfish OS Telepathy has no support for group chats (I'm slowly working on it together with reworked group chat support for KDE and others) and telepathy-idle is one of a very few Connection Managers which seems to be not packaged yet.
It is up to you to decide :)

[jtojnar]

Please retarget the PR to branch telepathy-idle-0.2 so this can go for telepathy-idle-0.2.3 release (I have no idea if we'll ever have 0.3 release).

Done.

By default, the timeout is 30 seconds and only less than half of twisted tests manage to get run.

Hm. ninja test does not fail for me: I think I have all tests passed in about 15 seconds.
Yet it won't hurt to increase the timeout.

For me some of the twisted tests are running too long before timing out internally, which makes the rest of the test not get run at all.

1/4 telepathy-idle / test_ctcp_tokenize         OK             0.01s
2/4 telepathy-idle / test_ctcp_kill_blingbling  OK             0.01s
3/4 telepathy-idle / test_text_encode_and_split OK             0.01s
4/4 telepathy-idle:twisted / check              FAIL           43.50s (exit status 1)

Ok:                 3   
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   


The output from the failed tests:

4/4 telepathy-idle:twisted / check              FAIL           43.50s (exit status 1)

--- command ---
09:11:54 IDLE_TEST_SLEEP='' IDLE_ABS_TOP_SRCDIR='/build/telepathy-idle' IDLE_TEST_UNINSTALLED='1' IDLE_ABS_TOP_BUILDDIR='/build/telepathy-idle/build' /build/telepathy-idle/build/tests/twisted/run-test.sh
--- Listing only the last 100 lines from a long log. ---
FAIL: connect/connect-success-ssl.py (1)
Testing connect/connect-reject-ssl.py ...
FAIL: connect/connect-reject-ssl.py (1)
Testing connect/connect-fail.py ...
PASS: connect/connect-fail.py
Testing connect/connect-fail-ssl.py ...
PASS: connect/connect-fail-ssl.py
Testing connect/disconnect-before-socket-connected.py ...
PASS: connect/disconnect-before-socket-connected.py
Testing connect/disconnect-during-cert-verification.py ...
FAIL: connect/disconnect-during-cert-verification.py (1)
Testing connect/ping.py ...
PASS: connect/ping.py
Testing connect/server-quit-ignore.py ...
PASS: connect/server-quit-ignore.py
Testing connect/server-quit-noclose.py ...
PASS: connect/server-quit-noclose.py
Testing connect/socket-closed-after-handshake.py ...
PASS: connect/socket-closed-after-handshake.py
Testing connect/socket-closed-during-handshake.py ...
PASS: connect/socket-closed-during-handshake.py
Testing connect/invalid-nick.py ...
PASS: connect/invalid-nick.py
Testing contacts.py ...
PASS: contacts.py
Testing channels/join-muc-channel.py ...
PASS: channels/join-muc-channel.py
Testing channels/join-muc-channel-bouncer.py ...
PASS: channels/join-muc-channel-bouncer.py
Testing channels/requests-create.py ...
PASS: channels/requests-create.py
Testing channels/requests-muc.py ...
PASS: channels/requests-muc.py
Testing channels/muc-channel-topic.py ...
PASS: channels/muc-channel-topic.py
Testing channels/muc-destroy.py ...
PASS: channels/muc-destroy.py
Testing channels/room-list-channel.py ...
PASS: channels/room-list-channel.py
Testing channels/room-list-multiple.py ...
PASS: channels/room-list-multiple.py
Testing messages/accept-invalid-nicks.py ...
PASS: messages/accept-invalid-nicks.py
Testing messages/contactinfo-request.py ...
PASS: messages/contactinfo-request.py
Testing messages/messages-iface.py ...
PASS: messages/messages-iface.py
Testing messages/message-order.py ...
PASS: messages/message-order.py
Testing messages/leading-space.py ...
PASS: messages/leading-space.py
Testing messages/long-message-split.py ...
PASS: messages/long-message-split.py
Testing messages/room-contact-mixup.py ...
PASS: messages/room-contact-mixup.py
Testing messages/room-config.py ...
PASS: messages/room-config.py
--- stderr ---
Traceback (most recent call last):
  File "/build/telepathy-idle/tests/twisted/idletest.py", line 246, in exec_test_deferred
    f(queue, bus, conn, server)
  File "/build/telepathy-idle/tests/twisted/connect/connect-close-ssl.py", line 16, in test
    e = q.expect('dbus-signal', signal='NewChannels')
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 141, in expect
    event = self.wait()
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 245, in wait
    raise TimeoutError
servicetest.TimeoutError
Traceback (most recent call last):
  File "/build/telepathy-idle/tests/twisted/idletest.py", line 246, in exec_test_deferred
    f(queue, bus, conn, server)
  File "/build/telepathy-idle/tests/twisted/connect/connect-success-ssl.py", line 16, in test
    e = q.expect('dbus-signal', signal='NewChannels')
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 141, in expect
    event = self.wait()
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 245, in wait
    raise TimeoutError
servicetest.TimeoutError
Traceback (most recent call last):
  File "/build/telepathy-idle/tests/twisted/idletest.py", line 246, in exec_test_deferred
    f(queue, bus, conn, server)
  File "/build/telepathy-idle/tests/twisted/connect/connect-reject-ssl.py", line 16, in test
    e = q.expect('dbus-signal', signal='NewChannels')
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 141, in expect
    event = self.wait()
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 245, in wait
    raise TimeoutError
servicetest.TimeoutError
Traceback (most recent call last):
  File "/build/telepathy-idle/tests/twisted/idletest.py", line 246, in exec_test_deferred
    f(queue, bus, conn, server)
  File "/build/telepathy-idle/tests/twisted/connect/disconnect-during-cert-verification.py", line 15, in test
    e = q.expect('dbus-signal', signal='NewChannels')
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 141, in expect
    event = self.wait()
  File "/build/telepathy-idle/tests/twisted/servicetest.py", line 245, in wait
    raise TimeoutError
servicetest.TimeoutError
-------

Not sure how to fix that, though so I am disabling the twisted tests on NixOS for now.

About the license:

Sorry, I meant to link 3a1ce69#r43789669 but my clipboard malfunctioned.

Though it was slightly confusing that some files are licensed as LGPL-2.1-only and others as LGPL-2.1-or-later.

I would expect LGPL-2.1-or-later would allow people to enjoy new rights provided by future versions, while still allowing vendors to tivoize to their heart's content but do not care enough to contact all past contributors to extend the terms to LGPL2.1+ like I am doing with selfoss.

[jtojnar]

@Kaffeine Since the copyright change was dropped (presumably, I do not remember), do we need to do anything else here?