Skip to content

Updated the OPTIONS handler to return a 204 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhbdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated the OPTIONS handler to return a 204 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions runners/client/ClientRunner.cpp
View file
Open in desktop
Copy link

@alikomitekaraj-droid alikomitekaraj-droid Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runners/client/ClientRunner.cpp

Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,19 @@ void ClientRunner::receive_http_request(
std::unique_ptr<ton::http::HttpRequest> request, std::shared_ptr<ton::http::HttpPayload> payload,
Copy link

@alikomitekaraj-droid alikomitekaraj-droid Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

td::Promise<std::pair<std::unique_ptr<ton::http::HttpResponse>, std::shared_ptr<ton::http::HttpPayload>>> promise) {
if (request->method() == "OPTIONS") {
// TODO: return 204
std::string data = "<http><body>OK</body></http>";
http_send_static_answer(std::move(data), std::move(promise));
auto response =
ton::http::HttpResponse::create("HTTP/1.0", static_cast<ton::http::HttpStatusCode>(204), "no content", false,
false)
.move_as_ok();
response->add_header(ton::http::HttpHeader{"Access-Control-Allow-Origin", "*"});
response->add_header(ton::http::HttpHeader{"Access-Control-Allow-Methods", "GET, POST, OPTIONS"});
response->add_header(ton::http::HttpHeader{"Access-Control-Allow-Headers", "Content-Type, Authorization"});
response->add_header(ton::http::HttpHeader{"Content-Length", "0"});
response->complete_parse_header();

auto empty_payload = response->create_empty_payload().move_as_ok();
empty_payload->complete_parse();
promise.set_result(std::make_pair(std::move(response), std::move(empty_payload)));
return;
}
if (request->url() == "/v1/models") {
Expand Down