malformed request when max option is not defined#2
Open
mef wants to merge 3 commits intoTeehanLax:masterfrom
Open
malformed request when max option is not defined#2mef wants to merge 3 commits intoTeehanLax:masterfrom
mef wants to merge 3 commits intoTeehanLax:masterfrom
Conversation
… inside SearchResult.toXML function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example from README.md (basic use, step 4) used to crash the process, whereas running examples.basic.js worked fine.
It turned out that this was because when option "max" is omitted, the XML did not encode any document, as variable length only got defined when max exists.
Attached code fixes this by defining the variable length when max is not set.