Skip to content

Fixes following testing on TD-6226 - #1887

Merged
AnjuJose011 merged 2 commits into
RCfrom
Develop/Fixes/TD-6226-Responding-to-testing-issues-raised-in-updating-nhsuk-frontend-to-v10
Aug 12, 2026
Merged

Fixes following testing on TD-6226#1887
AnjuJose011 merged 2 commits into
RCfrom
Develop/Fixes/TD-6226-Responding-to-testing-issues-raised-in-updating-nhsuk-frontend-to-v10

Conversation

@frank-hee

@frank-hee frank-hee commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

JIRA link

TD-6226

Description

Responding to tests on TD-6226

1 & 2 - confirmed can no longer reproduce

3 - Removed unnecessary code from \Views\Shared\Tenant\LearningHub_Layout.cshtml

4 - Turned off borders on expander
image

5 - Removed break word settings on filter labels resetting to current LH standard. These will be replaced with quickfilters component soon.
image

6 - Same issue as #4 & 5
image
image

7 - Box removed from top, Catalogues displayed in card form, alignment difference intended
image

8 - back link fixed
image

9 - removed beta log-in tag from Log in button
image

10 - Back link fixed
image

11 - Footer date made automatic for current year
image

12 - working as intended

13 & 16 - button types and styles updated
image

14 - Button set to secondary-solid type
image

15 - Icon, button and My account text now all one link as per current LH linking to My Account
image

17 - overflow-wrap removed from buttons
image

18 - filter buttons now WCAG 2 compliant, same colours as existing LH and removed visited link default purple setting
image

19 - autosuggest subtexxt set to 100%
image

20 - Conditional item radio button scss fixed.
image

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • [x ] Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@frank-hee frank-hee self-assigned this Aug 11, 2026
@frank-hee frank-hee added the bug Something isn't working label Aug 11, 2026
@frank-hee
frank-hee requested review from AnjuJose011 and OluwatobiAwe and removed request for swapnamol-abraham August 11, 2026 15:20
@AnjuJose011
AnjuJose011 merged commit 92c5fa8 into RC Aug 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants