Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IN PROGRESS] UI2 changes #556

Closed
wants to merge 581 commits into from
Closed

[IN PROGRESS] UI2 changes #556

wants to merge 581 commits into from

Conversation

IvRRimum
Copy link
Contributor

@IvRRimum IvRRimum commented Oct 22, 2021 •
edited
Loading

  • Replace favicons(without white background)
  • Video item design
  • No videos in my feed yet
  • Change font to Montserrat
  • No subscriptions yet
  • Click on logo, take to root path
  • Move donations and github link to fixed location at the bottom right of the screen.
  • Make logout button work
  • If a person is not logged in dont show Feeds and subscriptions nav items
  • Add notifications( on subscription add) use this https://github.com/kyvg/vue3-notification ?
  • login button when not logged in, logout when logged in
  • Feeds - filters by the design
  • Subscriptions - Import/export by the design
  • Add search to pages(trending, feed, channel view, search view)
  • Fix autocomplete location
  • Search page filters by design
  • Fix infinite scroll in search, channel view, feeds pages
  • notification popup not seeable on mobile devices
  • Save the status of menu bar(collapse/expand) in browser memory
  • Video comments infinity scrool

FireMasterK and others added 30 commits July 6, 2021 00:03
@FireMasterK
Add auto theme option.
a4915b3
@dependabot @FireMasterK
build(deps-dev): bump eslint-plugin-vue from 7.12.1 to 7.13.0
618f5bf 
Bumps [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) from 7.12.1 to 7.13.0.
- [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases)
- [Commits](vuejs/eslint-plugin-vue@v7.12.1...v7.13.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-vue
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FireMasterK
build(deps): bump dompurify from 2.2.9 to 2.3.0
885f34d 
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.9 to 2.3.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.2.9...2.3.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@FireMasterK
Add router caching. (TeamPiped#248)
0f0c424 
* Add router caching.

* Avoid memory leak by limiting cache size.

* Fix search result caching.

* Remove remains of previous player.

Fixes an issue where the spinner/loading from a previous player can show up in a cached page.
@FireMasterK
Add limited support for devices without MSE extensions. (TeamPiped#251)
144a176
@FireMasterK
Allow infinite sponsorblock skips when looping is selected.
dfd1dcc
@FireMasterK
readme: Mention support for IOS
10d5124
@FireMasterK
Remove login and feed in navbar.
2116202
@FireMasterK
Increase priority of search suggestions.
b5dc8f2 
Closes TeamPiped#252
@FireMasterK
Increase z-index to 10 for search container.
fa604a5 
Closes TeamPiped#253
@FireMasterK
Load shaka-player as soon as Player component is loaded.
97ec7b5
@FireMasterK
Use best stream when playing muxed video.
48085fa
@FireMasterK
Add picture in picture support.
8be5f44 
Closes TeamPiped#255
@dependabot @FireMasterK
build(deps): bump mux.js from 5.12.0 to 5.12.1
75324a8 
Bumps [mux.js](https://github.com/videojs/mux.js) from 5.12.0 to 5.12.1.
- [Release notes](https://github.com/videojs/mux.js/releases)
- [Changelog](https://github.com/videojs/mux.js/blob/main/CHANGELOG.md)
- [Commits](videojs/mux.js@v5.12.0...v5.12.1)

---
updated-dependencies:
- dependency-name: mux.js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FireMasterK
build(deps): bump css-loader from 5.2.6 to 5.2.7
9b71953 
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 5.2.6 to 5.2.7.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v5.2.6...v5.2.7)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@FireMasterK
Blur searchbox on enter.
44fd111 
Closes TeamPiped#260
@dependabot @FireMasterK
build(deps): bump css-loader from 5.2.7 to 6.0.0
3fceb8e 
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 5.2.7 to 6.0.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v5.2.7...v6.0.0)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FireMasterK
build(deps): bump aquiladev/ipfs-action from 0.1.5 to 0.1.6
56bc220 
Bumps [aquiladev/ipfs-action](https://github.com/aquiladev/ipfs-action) from 0.1.5 to 0.1.6.
- [Release notes](https://github.com/aquiladev/ipfs-action/releases)
- [Changelog](https://github.com/aquiladev/ipfs-action/blob/master/.release-it.json)
- [Commits](aquiladev/ipfs-action@v0.1.5...v0.1.6)

---
updated-dependencies:
- dependency-name: aquiladev/ipfs-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FireMasterK
build(deps): bump mux.js from 5.12.1 to 5.12.2
43c69e3 
Bumps [mux.js](https://github.com/videojs/mux.js) from 5.12.1 to 5.12.2.
- [Release notes](https://github.com/videojs/mux.js/releases)
- [Changelog](https://github.com/videojs/mux.js/blob/main/CHANGELOG.md)
- [Commits](videojs/mux.js@v5.12.1...v5.12.2)

---
updated-dependencies:
- dependency-name: mux.js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FireMasterK
build(deps): bump shaka-player from 3.1.1 to 3.2.0
fbb5c50 
Bumps [shaka-player](https://github.com/google/shaka-player) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/google/shaka-player/releases)
- [Changelog](https://github.com/google/shaka-player/blob/master/CHANGELOG.md)
- [Commits](shaka-project/shaka-player@v3.1.1...v3.2.0)

---
updated-dependencies:
- dependency-name: shaka-player
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@FireMasterK
Prefer av1, vp9 and then avc1.
2e5cbe6
@FireMasterK
Login and subscriptions. (TeamPiped#256)
363c514 
* WIP login and subscriptions.

* Add a working feed and unsubscribe button.

* Allow importing subscriptions from Google Takeout, NewPipe and Invidious.
@dependabot @FireMasterK
build(deps): bump uikit from 3.7.0 to 3.7.1
0800e98 
Bumps [uikit](https://github.com/uikit/uikit) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/uikit/uikit/releases)
- [Changelog](https://github.com/uikit/uikit/blob/develop/CHANGELOG.md)
- [Commits](uikit/uikit@v3.7.0...v3.7.1)

---
updated-dependencies:
- dependency-name: uikit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@garrettjoecox
Adjustments to WatchVideo.vue to be more responsive and more similar …
15d26c4 
…to Youtube's UI (TeamPiped#272)
@FireMasterK
readme: Update and add more cryptocurrencies.
586ef89
@garrettjoecox @FireMasterK
Give the video meta data section a bit of breathing room (TeamPiped#273)
a8973f8 
* Give the video meta data section a bit of breathing room

* Apply linter.

Co-authored-by: FireMasterK <[email protected]>
@garrettjoecox
Temporary fix for logo (TeamPiped#274)
31be1fc
@FireMasterK
Add support for Sponsorblock's Preview/Recap sections.
3c19023 
Closes TeamPiped#276
@FireMasterK
Add support for setting a default homepage.
aa206d5
@FireMasterK
Add ability to disable showing comments.
181c07a
@FireMasterK
Copy link
Member

No, I want them to be handled with webpack or something when building.

@IvRRimum
Copy link
Contributor Author

Ohh, makes sense

@IvRRimum
Copy link
Contributor Author

@FireMasterK Alright, thats it for this week, you can review(i will prob fix tomorrow) and merge.

@IvRRimum
Copy link
Contributor Author

Deployd this version here(if an1 watch to check it out live): https://piped.crypto-tzar.com/

ChunkyProgrammer
ChunkyProgrammer reviewed Oct 24, 2021
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
@vachan-maker
Copy link
Contributor

@IvRRimum This is how the codec selector looks like. It could use some improvement.
image

@vachan-maker
Copy link
Contributor

Notification popup is not visible on mobile devices.

@IvRRimum
Copy link
Contributor Author

@FireMasterK Are we good to merge?

@IvRRimum
Copy link
Contributor Author

Wait, no. Need to fix infinite scrool for comments

@IvRRimum
Copy link
Contributor Author

@FireMasterK Done

FireMasterK
FireMasterK requested changes Oct 31, 2021
View reviewed changes
src/components/WatchVideo.vue
@@ -14,7 +14,7 @@
<div v-if="video && !isEmbed" class="uk-container uk-container-xlarge">
<ErrorHandler v-if="video && video.error" :message="video.message" :error="video.error" />

<div v-show="!video.error">
<div v-show="!video.error" id="video-and-info">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using id, and document.getElement... You should use ref="name" and this.$refs.name

@VarLad
Copy link

VarLad commented Jan 15, 2022

This needs to implement Chapters now as well I guess?
@FireMasterK @IvRRimum

@Bnyro
Copy link
Member

Bnyro commented Sep 5, 2022

See #1391 for Piped's future UI

@Bnyro Bnyro closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer left review comments

@FireMasterK FireMasterK FireMasterK requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.