-
-
Notifications
You must be signed in to change notification settings - Fork 499
Refactor build and publishing setup #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
218ea36 to
733214f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the changes, but did not test them.
86f1d83 to
f40f4db
Compare
|
Signing support is still missing as that's needed for mavencentral |
|
I couldn't find classes from the Hence, I moved the javadoc, source and publishing setup to the extractor module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I compared all of the files and they mostly look good to me. I also tried building locally and I was able to run tests, and also to build NewPipe when depending on the local copy of NewPipeExtractor.
I couldn't find classes from the timeago-* modules in the currently generated jar file for the extractor nor do they seem to be getting generated separately or consumed in the NewPipe app. This made me assume that they are supposed to be consumed by the extractor and aren't supposed to be released.
You mean that the timeago-parser JAR is not needed externally? Yeah that's correct, timeago-parser is just a subproject used internally in NewPipeExtractor that shouldn't be published separately.
Signing support is still missing as that's needed for mavencentral
I think it's fine to proceed with this using environment variables. Then we can setup a CI action that creates a new release on mavencentral. However this should be done in a separate PR
fe3b69a to
dc313f3
Compare
Otherwise standard tasks are broken due to missing tags Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
b982a6d to
61d1260
Compare
* Add missing information in pom file * Add a new local maven repo to access the file easily * Relocate the publishing instructions to extractor module * Use the existing Gradle task to generate javadoc Signed-off-by: Aayush Gupta <[email protected]>
Only extractor has actual tests Signed-off-by: Aayush Gupta <[email protected]>
61d1260 to
bed47c4
Compare
I will do this in a separate PR |
Summary
This PR:
Due diligence