Add media.ccc specific parsing of recordings #1250
Open
+224
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of pushing the `media.ccc` recordings straight into the StreamExtractor straightjacket (which does not really provide the correct API for handling the semantics of the media.ccc data), we parse into an intermediate structure first that contains all relevant information about the different streams. This is required for correct handling of the different languages.
ShareASmile
added
media.ccc.de
Stypox
requested changes
Feb 26, 2025
| } | ||
|
|
||
| return videoStreams; | ||
| } | ||
|
|
||
| public List<MediaCCCRecording> getRecordings() { |
There was a problem hiding this comment.
Sorry for the late review. You should probably cache the value returned by getRecordings() to avoid recalculating it in getVideoStreams(), getAudioStreams() and getVideoOnlyStreams()
Comment on lines
+143
to
+147
| .flatMap(r -> | ||
| r instanceof MediaCCCRecording.Video | ||
| ? Stream.of((MediaCCCRecording.Video) r) | ||
| : Stream.empty() | ||
| ) |
There was a problem hiding this comment.
(also in other places)
Suggested change
| .flatMap(r -> | |
| r instanceof MediaCCCRecording.Video | |
| ? Stream.of((MediaCCCRecording.Video) r) | |
| : Stream.empty() | |
| ) | |
| .filter(MediaCCCRecording.Video::isInstance) | |
| .map(MediaCCCRecording.Video::cast) |
| MAIN, | ||
| /** A side-recording of a talk/event that has the slides full-screen. | ||
| * Usually if there is a slide-recording there is a MAIN recording as well */ | ||
| SLIDES |
There was a problem hiding this comment.
Probably we should add something like this but for videos, to distinguish between the main and secondary types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pushing the
media.cccrecordings straight into the StreamExtractor straightjacket (which does not really provide the correct API for handling the semantics of the media.ccc data), we parse into an intermediate structure first that contains all relevant information about the different streams.This is required for correct handling of the different languages.
It should not change the API, since its specfic to the media.ccc Extractor. I just type-cast in frankenplayer at the moment.
I skipped adding getters/setters in the MediaCCCRecording structs, once this repository is migrated to Kotlin (?), it would just be a data class.