Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: branch 링크 생성 API 구현 #246

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

leeeeeyeon
Copy link
Collaborator

@leeeeeyeon leeeeeyeon commented Jul 23, 2024

🛰️ Issue Number

#245

🪐 작업 내용

  • branch 링크 생성 API 구현 및 테스트 코드를 작성하였습니다.
    • Presigned URL 생성 API와 응답 DTO 양식이 동일하여 UrlResponse로 이름을 변경하여 공통으로 사용하도록 하였습니다.
  • infra 모듈의 YoutubeService와 FileService를 사용하는 API의 응답 DTO가 infra 모듈에 정의되어 있어 api 모듈로 이동시켰습니다.
    • Service 클래스에서는 DTO에 들어갈 데이터를 반환하고, DTO 생성 및 반환은 api 모듈에서 진행합니다.

📚 Reference

✅ Check List

  • DB 스키마가 일치하는지 확인했나요?
  • SonarLint를 반영하여 코드를 수정했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the 🎁 feature New feature or request label Jul 23, 2024
@leeeeeyeon leeeeeyeon self-assigned this Jul 23, 2024
@leeeeeyeon leeeeeyeon added the 🎫 test Test Code label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
...main/java/com/dilly/admin/api/AdminController.java 100.00% <100.00%> (ø) 9.00 <2.00> (?)
...c/main/java/com/dilly/application/FileService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/com/dilly/admin/api/FileController.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...main/java/com/dilly/application/BranchService.java 90.47% <90.47%> (ø) 2.00 <2.00> (?)
...ain/java/com/dilly/application/YoutubeService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Copy link

sonarcloud bot commented Jul 23, 2024

@leeeeeyeon leeeeeyeon merged commit 2ac9c30 into develop Jul 23, 2024
3 checks passed
@leeeeeyeon leeeeeyeon deleted the feature/create-branch-url branch July 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature New feature or request 🎫 test Test Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant