Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 나중에 보내는 선물박스의 gift null check 추가 #239

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

leeeeeyeon
Copy link
Collaborator

@leeeeeyeon leeeeeyeon commented Jun 30, 2024

🛰️ Issue Number

#238

🪐 작업 내용

  • 나중에 보내는 선물박스의 gift null check를 추가했습니다.

📚 Reference

✅ Check List

  • DB 스키마가 일치하는지 확인했나요?
  • SonarLint를 반영하여 코드를 수정했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the 🔨 fix Modifying previously implemented features label Jun 30, 2024
@leeeeeyeon leeeeeyeon self-assigned this Jun 30, 2024
Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
...in/java/com/dilly/gift/domain/giftbox/GiftBox.java 50.00% <ø> (ø) 1.00 <0.00> (?)
...ava/com/dilly/gift/application/GiftBoxService.java 37.71% <0.00%> (ø) 14.00 <0.00> (?)

@leeeeeyeon leeeeeyeon merged commit 3de7abe into develop Jun 30, 2024
3 checks passed
@leeeeeyeon leeeeeyeon deleted the feature/fix-delete-giftbox branch June 30, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 fix Modifying previously implemented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant