refactor: 선물을 열 수 있는지 판단하는 로직 리팩토링 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeeeyeon
added
🧼 refactor
|
leeeeeyeon
added a commit
that referenced
this pull request
Feb 9, 2024
* fix: 스티커 조회가 sequence 순으로 페이징되도록 수정 * refactor: 선물을 열 수 있는지 판단하는 로직 리팩토링 (#130) * refactor: 선물을 열 수 있는지 판단하는 로직 리팩토링 * remove: 사용하지 않는 변수 제거 * test: 받은 선물박스 페이징 쿼리 테스트 코드 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
X
🪐 작업 내용
getSentGiftBoxesBeforeLastGiftBoxDate테스트가 로컬에서는 통과함에도 불구하고 CI에서는 처음에 실패하고 re-run을 몇 번 하면 통과하는 이상한 현상이 발생하고 있습니다. 무의미한 CI 실패를 줄이고, 테스트 코드를 수정하기 위해 임시로 해당 테스트를 제거합니다.📚 Reference
X
✅ Check List