Skip to content

Feat : 문의하기 링크 수정 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m6z1 merged 2 commits into from
Feb 17, 2025
Merged

Feat : 문의하기 링크 수정 #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f1247a
feat: 문의하기 링크 수정
m6z1 Feb 15, 2025
ce2e4fd
build: 네트워크 보안 해결
m6z1 Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
android:allowBackup="true"
android:icon="@mipmap/ic_logo"
android:label="@string/app_name"
android:networkSecurityConfig="@xml/network_security_config"
Copy link
Contributor

@huiwoo-jo huiwoo-jo Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우리 http를 사용하는 부분이 없나용

Copy link
Member Author

@m6z1 m6z1 Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

있는데 manifest 속성 중 android:usesCleartextTraffic가 이미 true 값으로 설정이 되어있기에 해당 속성은 필요 없습니다. 그리고 network_security_config 파일 자체가 지금 깃에도 올라가있어서 url 이 노출되고 있는 중이라서욥

Copy link
Contributor

@huiwoo-jo huiwoo-jo Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 그렇군요!
그럼 지워도 괜찮겠네용

android:roundIcon="@mipmap/ic_logo_round"
android:supportsRtl="true"
android:theme="@style/Theme.YouDongKnowMe"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/dongyang/android/youdongknowme/ui/view/setting/SettingFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class SettingFragment : BaseFragment<FragmentSettingBinding, SettingViewModel>()
binding.btnSettingAppHelp.setOnClickListener {
val intent = Intent(
Intent.ACTION_VIEW,
Uri.parse("https://docs.google.com/forms/d/e/1FAIpQLSeRTKalenelmffTbCZeK4mqmQg0palobghkXSoie1FlmV22ZQ/viewform")
Uri.parse("https://tally.so/r/n9oq91")
)
startActivity(intent)
}
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/xml/network_security_config.xml
View file
Open in desktop

This file was deleted.

Loading