Max better pids #54
Max better pids #54
Conversation
|
You should definitely test this stuff before pulling it to main. Your changes seem ok other than the comments I made above, but you still need to make sure the code builds. |
maxspier
added this to the
Max not having to do PID for at least some amount of time milestone
jamesi8086
left a comment
jamesi8086
left a comment
There was a problem hiding this comment.
please use a java linter to fix formatting before merging
e.g.
https://code.visualstudio.com/docs/java/java-linting
still unsure what this is |
…ng but idk what happened there it is all red (/) Fixed conventional things (+) Added try_catch + an exception on the constructor just incase someone mistypes a config name and we don't want the whole robot angry (-) removed useless stuff (/) Due to common vote, renamed setAllusion() to setPosition()
Why cant we just create a fork at the beginning of the season???
jamesi8086
left a comment
jamesi8086
left a comment
There was a problem hiding this comment.
got a couple of things to fix there
|
better, but the build is broken (see CI failures) I hope @JayAgra has time to put in automatic linting into our github repos so that you/we can care less about manually conforming to Java code style, spacings, etc |
This is the new framework for PIDs. By the way, how do you do logs again?
For some reason, ya'll let me make it.It's pretty great.
How Has This Been Tested?
I didn't run any tests yet. (Ron respond to my discord messages please).Because I'm so good at coding, it will probably work. Still need to implement the antigrav but thats some AP calc BC stuff so it isn't really for me.
Please take a look and let me know what you like/dislike
Thx, and as always, "the world belongs to those who prepare for it today" (Malcolm X).