Control the lights on the gamepad using Serial #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
approved these changes
Feb 2, 2024
code_1.py
Outdated
| redValue = int(commandString[2:5]) | ||
| greenValue = int(commandString[5:8]) | ||
| blueValue = int(commandString[8:11]) | ||
| if not inRange(ledNumber, 1, 32): |
Contributor
There was a problem hiding this comment.
are these really not 0 indexed?
Author
There was a problem hiding this comment.
I did it this way to match the buttons, which start at 1 per the USB spec.
JohnGilb
approved these changes
Feb 2, 2024
| for /f %%D in ('wmic volume get DriveLetter^, Label ^| find "CIRCUITPY"') do set myDrive=%%D | ||
| echo %myDrive% | ||
|
|
||
| set myDrive=D: |
Contributor
There was a problem hiding this comment.
What happened here? Did deploy.cmd not find the CIRCUITPY drive on your machine? Did it show up with a different name?
Author
|
For whatever reason the original command worked in a console but not via
vscode. Is there a trick to it?
…On Fri, Feb 2, 2024, 2:05 PM JohnGilb ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In deploy.cmd
<#1 (comment)>
:
> @@ -1,6 +1,4 @@
-for /f %%D in ('wmic volume get DriveLetter^, Label ^| find "CIRCUITPY"') do set myDrive=%%D
-echo %myDrive%
-
+set myDrive=D:
What happened here? Did deploy.cmd not find the CIRCUITPY drive on your
machine? Did it show up with a different name?
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAX7YNLEFV6QUOJIRQCGXQDYRVPKFAVCNFSM6AAAAABCV7XIPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRQGQ3TQNJUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Huh, no clue. It doesn't make too much difference; we can mess with it later to see if there's some way to make it reliable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.