Skip to content

Chore/event name utility enhancement #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karnelll merged 4 commits into from
Nov 28, 2024
Merged

Chore/event name utility enhancement #99

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c853192
[refactor] Update exit modal functionality and improve data handling
karnelll Nov 28, 2024
6ae4346
[fix] implement feedback
karnelll Nov 28, 2024
bad29c2
[chore] enhance event name input utility
karnelll Nov 28, 2024
ef3edef
Merge branch 'main' into chore/event-name-utility-enhancement
karnelll Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions fe/src/app/eventcreate-page/components/EventNameInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@ export default function EventNameInput({
}: EventNameInputProps) {
const [hasUserEdited, setHasUserEdited] = useState(false);
const [isTyping, setIsTyping] = useState(false);
const showWarning = hasUserEdited && !isValidLength(cleanString(value), 1);

useEffect(() => {
if (!hasUserEdited) {
if (!hasUserEdited && !value) {
const newEventName: string = generateDefaultEventName(selectedLocation);
onChange(newEventName);
if (newEventName) {
onChange(newEventName);
}
}
}, [selectedLocation, onChange, hasUserEdited]);
}, [selectedLocation, onChange, hasUserEdited, value]);

const handleInputChange = useCallback(
(e: React.ChangeEvent<HTMLInputElement>) => {
Expand All @@ -51,6 +52,8 @@ export default function EventNameInput({
onChange("");
}, [onChange]);

const showWarning = hasUserEdited && !isValidLength(cleanString(value), 1);

return (
<div className={`relative flex flex-col mt-4 ${className}`}>
<label className="text-[#2c2c2c] text-[22px] font-semibold font-['Pretendard'] leading-[30px] mb-2">
Expand Down