챌린지 상세 페이지에서 도전 내용 인디케이터 변경 사항 반영 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soopeach
force-pushed
the
design/challenge_goal_indicator
branch
from
166a6ef to
7b99c6a
Compare
peter-j0y
approved these changes
Dec 5, 2024
| val progressBarColor = challengeColor.progressBarColor | ||
|
|
||
| val progress = | ||
| if (challenge.progress == null) 0f else requireNotNull(challenge.progress) / 100f |
Member
There was a problem hiding this comment.
requireNotNull을 쓰면 challenge.progress가 null이면 exception 나지 않나요? 아마 challenge.progress는 nullable한 상황이라 사용하셨을 것 같은데 다음과 같은 방식은 어떨까요?
Suggested change
| if (challenge.progress == null) 0f else requireNotNull(challenge.progress) / 100f | |
| val challengeProgress = challenge.progress | |
| if (challengProgress == null) 0f else challenge.progress / 100f |
| goal = "목표", | ||
| limit = when (challenge.challengeType) { | ||
| ChallengeType.LIFE -> { | ||
| "연속 " + challenge.period.toString() + "일" |
Member
There was a problem hiding this comment.
nit) "연속 ${challenge.period}일"로 하면 더 간결하게 할 수 있을 것 같아요!
| ) | ||
|
|
||
| Text( | ||
| text = "${deadLineInfo[0]}일 ${deadLineInfo[1]}시간 ${deadLineInfo[2]}분" + "남음", |
Member
There was a problem hiding this comment.
index exception이 날 수도 있을 것 같아서 default 값이 있으면 좋을 것 같긴하네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호
🥲 비고