챌린지 응답 모델 변경, 챌린지 완료 Api 연동 #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-j0y
approved these changes
Nov 21, 2024
| challenge.accTime, | ||
| challenge.badge.toBadge(), | ||
| challenge.calorie, | ||
| ChallengeType.getChallengeTypeByString(challenge.category ?: String.EMPTY), |
Member
There was a problem hiding this comment.
nit) 다음과 같이 줄여 볼 수 있을 것 같습니다!
Suggested change
| ChallengeType.getChallengeTypeByString(challenge.category ?: String.EMPTY), | |
| ChallengeType.getChallengeTypeByString(challenge.category.orEmpty()), |
Member
Author
There was a problem hiding this comment.
!! orEmpty 좋네요! 코틀린에서 자체적으로 있는 메서드인가요?
|
|
||
| val progress = if (challenge.process == null) 0f else requireNotNull(challenge.process) / 100f | ||
| val progress = | ||
| if (challenge.progress == null) 0f else requireNotNull(challenge.progress) / 100f |
Member
There was a problem hiding this comment.
코드 로직상 문제는 없지만 중복 null 체크 인 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호
🥲 비고