Skip to content

[FIX] 서재 조회 무한스크롤 방식 수정 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rinarina0429 merged 2 commits into from
Jul 5, 2025
Merged

[FIX] 서재 조회 무한스크롤 방식 수정 #367

rinarina0429 merged 2 commits into from
Jul 5, 2025

Conversation

@rinarina0429
Copy link
Member

@rinarina0429 rinarina0429 commented Jul 1, 2025 •
edited
Loading

Related Issue

Key Changes

  • 다른 api에서는 최신순, 오래된순 관계없이 초기호출 때에는 lastNovelId를 0으로 설정하면 됐었는데, 서재 조회 시에는 최신순 초기 호출 때에 lastNovelId를 9999로 설정했어야 해, 이를 수정하였습니다.
  • 이전 pr에서 SORT TYPE을 enum으로 관리하면 좋을 것 같다는 리뷰를 남겨주셔서 sortCriteria를 사용하도록 방식을 변경하였습니다.

To Reviewers

References

@rinarina0429 rinarina0429 self-assigned this Jul 1, 2025
@rinarina0429 rinarina0429 marked this pull request as draft July 1, 2025 10:24
@rinarina0429 rinarina0429 marked this pull request as ready for review July 1, 2025 12:10
GiJungPark
GiJungPark reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@GiJungPark GiJungPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드립니다 :)

src/main/java/org/websoso/WSSServer/service/UserNovelService.java

boolean isOwner = visitor.getUserId().equals(ownerId);
boolean isAscending = sortType.equalsIgnoreCase(SORT_TYPE_OLDEST);
boolean isAscending = sortCriteria == OLD;
Copy link
Contributor

@GiJungPark GiJungPark Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3; SortCriteria ENUM에 isOld메서드를 만들어서 검증하는게 더 좋을것 같아요!
static import 인데, OLD 여서 헷갈릴 수 있을것 같아요 :)

EunjeongHeo
EunjeongHeo approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@EunjeongHeo EunjeongHeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨습니닷

@rinarina0429 rinarina0429 merged commit 1ff0ff0 into dev Jul 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GiJungPark GiJungPark GiJungPark left review comments

@EunjeongHeo EunjeongHeo EunjeongHeo approved these changes

@Kim-TaeUk Kim-TaeUk Awaiting requested review from Kim-TaeUk

@sansan20535 sansan20535 Awaiting requested review from sansan20535

Assignees

@rinarina0429 rinarina0429

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FIX] 서재 조회 무한스크롤 방식 수정

4 participants

@rinarina0429 @GiJungPark @EunjeongHeo