Skip to content

[REFACTOR] 서재 관련 API 리뷰 반영 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rinarina0429 merged 3 commits into from
Aug 2, 2025
Merged

[REFACTOR] 서재 관련 API 리뷰 반영 #366

rinarina0429 merged 3 commits into from
Aug 2, 2025

Conversation

@rinarina0429
Copy link
Member

@rinarina0429 rinarina0429 commented Jun 28, 2025 •
edited
Loading

Related Issue

Key Changes

이전 pr의 리뷰를 반영하지 못한 것들이 있어 해당 pr에서 반영하였습니다.

To Reviewers

  • 더 남겨주실 리뷰 있으면 남겨주시고 전달해주세요옹
  • 소프트 딜리트의 경우에는 서재소소 일정이 조금 미뤄져서 + 볼륨이 그냥 리팩토링보다 많이 커질 것 같아 따로 pr 만들도록 하겠습니다!
  • 의진님 리뷰 중 sort 방식 enum으로 바꾸는건 관련 변경사항이 타 이슈에서 있어서 issue/[FIX] 서재 조회 무한스크롤 방식 수정 #365 에서 다루도록 하겠습니다

References

@rinarina0429 rinarina0429 self-assigned this Jun 28, 2025
GiJungPark
GiJungPark approved these changes Jun 28, 2025
View reviewed changes
Copy link
Contributor

@GiJungPark GiJungPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@rinarina0429 rinarina0429 merged commit 7db2a02 into dev Aug 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GiJungPark GiJungPark GiJungPark approved these changes

@sansan20535 sansan20535 sansan20535 approved these changes

@EunjeongHeo EunjeongHeo Awaiting requested review from EunjeongHeo

@Kim-TaeUk Kim-TaeUk Awaiting requested review from Kim-TaeUk

Assignees

@rinarina0429 rinarina0429

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REFACTOR] 서재 관련 API 리뷰 반영

4 participants

@rinarina0429 @GiJungPark @sansan20535