[REFACTOR] 오늘의 발견 API 리팩토링 #323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinarina0429
commented
Mar 21, 2025
Comment on lines
-26
to
-32
| .map(novelId -> jpaQueryFactory | ||
| .selectFrom(feed) | ||
| .leftJoin(feed.likes, like) | ||
| .where(feed.novelId.eq(novelId)) | ||
| .groupBy(feed.feedId) | ||
| .orderBy(like.count().desc()) | ||
| .fetchFirst()) |
Member
Author
There was a problem hiding this comment.
기존에는 novelId마다 쿼리가 발생함
ChaeAg
approved these changes
Mar 21, 2025
Member
ChaeAg
left a comment
ChaeAg
left a comment
There was a problem hiding this comment.
오 쿼리 최적화를 진행하셨군요! 멋진데요? 테스트 해보셨을때 결과는 어땠나요 ㅎㅎ 많이 좋아졌나요?
Kim-TaeUk
reviewed
Apr 9, 2025
Member
Kim-TaeUk
left a comment
Kim-TaeUk
left a comment
There was a problem hiding this comment.
요거 인증인가 리팩터링한거 반영되면 수정해서 붙이죠!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
findPopularFeedsByNovelIds()함수에서 쿼리 최적화를 진행해보았습니다.findPopularFeedsByNovelIds()에서 바로 Map을 반환하게 하여createFeedMap()함수를 제거했습니다.To Reviewers
References