[FEAT] 알림 생성 API 구현 #304
Merged
[FEAT] 알림 생성 API 구현 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaeAg
reviewed
Feb 15, 2025
Member
ChaeAg
left a comment
ChaeAg
left a comment
There was a problem hiding this comment.
수고하셨습니다!! 🥰
코멘트 몇개 남겼어요 확인 부탁드려요 ㅎㅎ
src/main/java/org/websoso/WSSServer/dto/notification/NotificationCreateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/websoso/WSSServer/service/NotificationService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/websoso/WSSServer/service/NotificationService.java
Outdated
Show resolved
Hide resolved
ChaeAg
approved these changes
Feb 16, 2025
Member
ChaeAg
left a comment
ChaeAg
left a comment
There was a problem hiding this comment.
굿!!!!!!! 수고 정말 많으셨어요 ㅎㅎㅎ 수정사항 확인 완료!!
Kim-TaeUk
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
Notification 中 공지/이벤트 생성 API를 구현했습니다.
ADMIN계정으로 접속해야 합니다.notification_title,notification_body,notification_detail이 모두 varchar(255)로 적용이 되어 있었기 때문에 기획과 이야기 후 각각 200자, 200자, 2000자로 수정하였으며, 해당 변경사항은 아직 DEV_DB에만 반영된 상태입니다."","notificationDetail"로 넘기기로 하였습니다.To Reviewers
References