[FIX] 알림 목록 조회 API 수정 #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaeAg
commented
Feb 10, 2025
src/main/java/org/websoso/WSSServer/dto/notification/NotificationInfo.java
Show resolved
Hide resolved
rinarina0429
approved these changes
Feb 11, 2025
Member
rinarina0429
left a comment
rinarina0429
left a comment
There was a problem hiding this comment.
이것 때문에 아요에서 읽음처리 과정에 이상이 있었나보네요! 로깅까지👍🏻👍🏻 수고하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
기존 알림 목록 조회 API의 공지 알림 유형을 확인하는 로직에서
Set.of("공지", "이벤트")와 같이 하드코딩된 방식을 사용하고 있었는데, 서버 내 공지의 명칭이 "공지" → "공지사항"으로 변경되면서 예외가 발생하는 문제가 있었습니다.이를 해결하기 위해 공지 알림 유형을 확인하는 로직을 메서드를 활용하는 방식으로 변경하였습니다.
추가 변경 사항
(이 부분은 해당 PR의 주요 기능과는 별개지만, 디버깅을 위한 개선 사항입니다.)
To Reviewers
References