Skip to content

[FIX] SP2 QA 관련 오류 해결 - UX라이팅 수정 #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-TaeUk merged 2 commits into from
Feb 11, 2025
Merged

[FIX] SP2 QA 관련 오류 해결 - UX라이팅 수정 #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d15297
[FIX] UX 라이팅 미반영 버그 수정
Kim-TaeUk Feb 1, 2025
6c2948c
[FIX] 12자 미만일 때 작은 따옴표 누락 버그 수정
Kim-TaeUk Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/websoso/WSSServer/service/CommentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ private void sendCommentPushMessageToFeedOwner(User user, Feed feed) {
NotificationType notificationTypeComment = notificationTypeRepository.findByNotificationTypeName("댓글");

String notificationTitle = createNotificationTitle(feed);
String notificationBody = String.format("%s님이 내 수다글에 댓글을 남겼어요", user.getNickname());
String notificationBody = String.format("%s님이 내 수다글에 댓글을 남겼어요.", user.getNickname());
Long feedId = feed.getFeedId();

Notification notification = Notification.create(
Expand Down Expand Up @@ -99,9 +99,10 @@ private void sendCommentPushMessageToFeedOwner(User user, Feed feed) {
private String createNotificationTitle(Feed feed) {
if (feed.getNovelId() == null) {
String feedContent = feed.getFeedContent();
return feedContent.length() <= 12
feedContent = feedContent.length() <= 12
? feedContent
: "'" + feedContent.substring(0, 12) + "...'";
: feedContent.substring(0, 12);
return "'" + feedContent + "...'";
}
Novel novel = novelService.getNovelOrException(feed.getNovelId());
return novel.getTitle();
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/websoso/WSSServer/service/FeedService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,10 @@ private void sendLikePushMessage(User liker, Feed feed) {
private String createNotificationTitle(Feed feed) {
if (feed.getNovelId() == null) {
String feedContent = feed.getFeedContent();
return feedContent.length() <= 12
feedContent = feedContent.length() <= 12
? feedContent
: "'" + feedContent.substring(0, 12) + "...'";
: feedContent.substring(0, 12);
return "'" + feedContent + "...'";
}
Novel novel = novelService.getNovelOrException(feed.getNovelId());
return novel.getTitle();
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/websoso/WSSServer/service/PopularFeedService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,10 @@ private String createNotificationBody(Feed feed) {
private String generateNotificationBodyFragment(Feed feed) {
if (feed.getNovelId() == null) {
String feedContent = feed.getFeedContent();
return feedContent.length() <= 12
feedContent = feedContent.length() <= 12
? feedContent
: "'" + feedContent.substring(0, 12) + "...'";
: feedContent.substring(0, 12);
return "'" + feedContent + "...'";
}
Novel novel = novelService.getNovelOrException(feed.getNovelId());
return String.format("<%s>", novel.getTitle());
Expand Down
Loading