[FEAT] 홈화면 알림 빨간점 여부 조회 기능 구현 #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaeAg
approved these changes
Jan 17, 2025
Member
ChaeAg
left a comment
ChaeAg
left a comment
There was a problem hiding this comment.
굿굿입니다! :>
코멘트 하나 남겼으니 확인바래요~!~!
엔드포인트는 흠 boolean값만을 응답하니까 /has-unread, /unread-check정도 생각나는데 기가막힌 아이디어는 없는 것 같아유 🥲
+현재 API 이름이 홈 화면 빨간점 여부 조회로 작성되어 있는데, 유저 비열람 알림 존재 여부 조회 처럼 기능의 목적을 명확하게 반영하는 이름이 더 적절할 것 같습니다.
src/main/java/org/websoso/WSSServer/repository/NotificationRepository.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
홈 화면에서 알림을 안읽었을 시 나타나는 빨간 점의 여부를 조회하는 기능을 구현했습니다.
Notion API 명세서
To Reviewers
/notifications/unread인데, 뭔가 딱 좋다! 느낌이 아니라서, 한번씩 확인 부탁드립니다! 바꿀만한게 있으면 남겨주세요!References