[FEAT] NoticeCategory 추가#254
Closed
rinarina0429 wants to merge 8 commits intodevfrom
Closed
Conversation
ChaeAg
reviewed
Jan 9, 2025
Member
ChaeAg
left a comment
ChaeAg
left a comment
There was a problem hiding this comment.
수고하셨습니다! 이런 태스크가 남몰래 있었군용 🤔
제가 남긴 코멘트 한 번 확인 부탁드립니다~!~!
| .noticeTitle(noticePostRequest.noticeTitle()) | ||
| .noticeContent(noticePostRequest.noticeContent()) | ||
| .userId(noticePostRequest.userId()) | ||
| .noticeCategory(getNoticeCategoryOrException(noticePostRequest.noticeCategoryId())) |
Member
There was a problem hiding this comment.
P3; 해당 로직에서 공지 카테고리 ID를 받아 공지 카테고리 엔티티를 조회하도록 구현하셨는데, NoticeCategory 엔티티의 noticeCategoryName 컬럼을 활용해보는 건 어떨까요? 현재 방식은 카테고리 ID를 이용해서 카테고리 종류가 많아질 경우 클라이언트가 각 ID를 일일이 외워야 한다는 점에서 다소 불편할 수 있을 것 같다는 생각이 듭니당
카테고리 이름을 활용하면 클라이언트 입장에서 더 유연한 접근이 가능해질 것 같아요!
Member
Author
There was a problem hiding this comment.
아하! 클라에서 사용하지 않는 api라 그냥 이렇게 만들었는데 저희가 그냥 포스트맨에서 쓰기에도 그게 편하겠네요. 수정하겠슴다~!👍🏻👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
공지를 내려주는 방식에 변경사항이 있었습니다.
이에 NoticeCategory를 추가하고 이를 기존 코드에 반영했습니다.
To Reviewers
테이블 변경사항은 DEV DB에만 반영해뒀습니다! 추후 머지되면 PROD DB에도 반영하겠습니다~
References