-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 프로필 아바타 추가 #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 프로필 아바타 추가 #774
Changes from all commits
ea5d5c0
a1d4a35
1378724
45e466f
662498d
294c253
4a3779e
b12fe9e
6a4ad56
c6852aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| package com.into.websoso.data.model | ||
|
|
||
| data class AvatarEntity( | ||
| val avatarId: Int, | ||
| val avatarId: Long, | ||
| val avatarName: String, | ||
| val avatarLine: String, | ||
| val avatarProfileImage: String, | ||
| val avatarImage: String, | ||
| val isRepresentative: Boolean, | ||
| ) |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||||||||||||||||||||||||||||||
| package com.into.websoso.ui.profileEdit | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| import android.graphics.Rect | ||||||||||||||||||||||||||||||||||
| import android.view.View | ||||||||||||||||||||||||||||||||||
| import androidx.recyclerview.widget.RecyclerView | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| class ColumnSpacingItemDecoration( | ||||||||||||||||||||||||||||||||||
| private val spanCount: Int, | ||||||||||||||||||||||||||||||||||
| private val spacing: Int, | ||||||||||||||||||||||||||||||||||
| ) : RecyclerView.ItemDecoration() { | ||||||||||||||||||||||||||||||||||
| override fun getItemOffsets( | ||||||||||||||||||||||||||||||||||
| outRect: Rect, | ||||||||||||||||||||||||||||||||||
| view: View, | ||||||||||||||||||||||||||||||||||
| parent: RecyclerView, | ||||||||||||||||||||||||||||||||||
| state: RecyclerView.State, | ||||||||||||||||||||||||||||||||||
| ) { | ||||||||||||||||||||||||||||||||||
| val position = parent.getChildAdapterPosition(view) | ||||||||||||||||||||||||||||||||||
| val column = position / spanCount | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| if (column > 0) { | ||||||||||||||||||||||||||||||||||
| outRect.left = spacing | ||||||||||||||||||||||||||||||||||
| } else { | ||||||||||||||||||||||||||||||||||
| outRect.left = 0 | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+17
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 컬럼 계산 로직 오류 수정 필요 Line 18의 컬럼 계산이 잘못되었습니다. 현재 코드는 나눗셈( 현재 동작 (잘못됨):
올바른 동작:
🔎 수정 제안 val position = parent.getChildAdapterPosition(view)
- val column = position / spanCount
+ val column = position % spanCount
if (column > 0) {
outRect.left = spacing📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 5039
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 604
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 136
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 413
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 11184
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 2080
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 664
필드 매핑 마이그레이션 완료 필요 -
avatarThumbnail참조 남아있음.AvatarMapper가
avatarProfile과avatarImage로 변경되었으나, 하위 계층 코드가 여전히avatarThumbnail필드를 사용하고 있습니다. ViewModel에서 수동으로avatarProfile → avatarThumbnail으로 매핑 중이지만, 다음 위치들도 함께 업데이트되어야 합니다:ProfileEditUiModel.kt:11-avatarThumbnail필드를avatarProfile로 변경ProfileEditViewModel.kt:249, 282-avatarProfile직접 사용으로 변경ProfileEditActivity.kt:276-279- 메서드명 및 파라미터 업데이트UserMapper.kt:27- 매핑 필드명 업데이트 필요