Skip to content

Conversation

@Chuseok22
Copy link
Member

@Chuseok22 Chuseok22 commented Jan 5, 2026

✨ 변경 사항


✅ 테스트


  • 수동 테스트 완료
  • 테스트 코드 완료

Summary by CodeRabbit

릴리스 노트

  • Refactor
    • 티켓 오픈 날짜 계산 로직을 최적화하여 다양한 날짜 시나리오에서 보다 안정적으로 처리하도록 개선했습니다.

✏️ Tip: You can customize this high-level summary in your review settings.

Chuseok22 and others added 2 commits January 5, 2026 16:56
…최신순_오픈일순_변경_시_응답값_동일

공연_필터링_조건_최신순_오픈일순_변경_시_응답값_동일 : feat : 선예매 오픈일, 일반예매 오픈일 중 빠른 데이터를 기…
@Chuseok22 Chuseok22 merged commit b878f12 into main Jan 5, 2026
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

Caution

Review failed

The pull request is closed.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'ignored_branch'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

ConcertRepositoryImpl의 SQL 쿼리에서 가장 빠른 티켓 오픈 날짜 계산 로직을 least() 함수에서 CASE WHEN 식으로 변경했습니다. 새로운 로직은 사전 오픈 날짜와 일반 오픈 날짜 중 null을 제외하고 더 빠른 날짜를 선택하도록 처리합니다.

Changes

Cohort / File(s) Change Summary
Ticket Open Date Query Logic
ticketmate-concert/src/main/java/com/ticketmate/backend/concert/infrastructure/repository/ConcertRepositoryImpl.java
earliestOpenDateExpression 계산을 SQL least() 템플릿에서 CASE 기반 식으로 변경. preOpenDateExpression과 generalOpenDateExpression 간의 null 처리 및 최솟값 선택 로직을 개선하여 filteredConcert 및 filteredConcertForAdmin 쿼리에 모두 적용

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

fix

Poem

🐰 날짜들이 춤을 춘다네,
사전 오픈, 일반 오픈의 춤,
CASE 문으로 순서 정하고,
null도 척척 피해내며,
가장 빠른 날이 승리하네! ✨

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab1091a and 1c6183d.

📒 Files selected for processing (1)
  • ticketmate-concert/src/main/java/com/ticketmate/backend/concert/infrastructure/repository/ConcertRepositoryImpl.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants