-
Notifications
You must be signed in to change notification settings - Fork 0
메시지 피드백 등록 API 구현 #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ckdals4600
wants to merge
1
commit into
main
Choose a base branch
from
feature/#151-feedback-add-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
메시지 피드백 등록 API 구현 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 코드 커버리지 리포트
|
fa41066 to
5b7287f
Compare
minibr
reviewed
Dec 19, 2025
src/main/java/com/sofa/linkiving/domain/chat/controller/FeedbackController.java
Outdated
Show resolved
Hide resolved
5b7287f to
11072eb
Compare
Goder-0
reviewed
Dec 30, 2025
src/main/java/com/sofa/linkiving/domain/chat/facade/FeedbackFacade.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sofa/linkiving/domain/chat/error/MessageErrorCode.java
Outdated
Show resolved
Hide resolved
02dfb6c to
2361359
Compare
Goder-0
reviewed
Jan 2, 2026
src/main/java/com/sofa/linkiving/domain/chat/dto/request/AddFeedbackReq.java
Show resolved
Hide resolved
88317fd to
38fc9a9
Compare
38fc9a9 to
c1761bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 설명
POST) 구현작업 내용
1. API 구현 (
FeedbackController)POST /v1/messages/{messageId}/feedbackAddFeedbackReq(감정sentiment, 의견text).text는null입력을 허용함.feedbackId반환.{ "success": true, "status": "OK", "message": "피드백이 등록되었습니다.", "data": { "id": 15 } }FeedbackApi인터페이스를 통해 API 명세를 정의함.2. 아키텍처 및 로직 (
FeedbackFacade)FeedbackFacade가 트랜잭션을 관리하며MessageService와FeedbackService를 조율함.ChatController의 비대화를 방지하기 위해domain.chat.controller패키지 내에FeedbackController를 별도로 생성함.3. Service 로직 (CQS)
MessageService:MessageQueryService를 통해messageId로 메시지를 조회하고, 존재하지 않을 경우CHAT_NOT_FOUND예외를 발생시킴.FeedbackService:FeedbackCommandService를 통해 피드백 데이터를 DB에 저장함.4. 에러 처리 (
MessageErrorCode)MessageErrorCode.CHAT_NOT_FOUND에러 코드를 정의5. 테스트 작성 (Test Coverage)
FeedbackIntegrationTest):sentiment) 누락 시400 Bad Request반환을 확인함.404 Not Found(MessageErrorCode.CHAT_NOT_FOUND) 반환을 확인함.FeedbackFacadeTest: Mocking을 통해 메시지 조회 후 피드백 저장으로 이어지는 호출 순서를 검증함.FeedbackServiceTest: 요청 데이터가 올바르게 엔티티로 변환되어 저장되는지 테스트함.