Skip to content

πŸ”€ :: (#410) - refactor integrating keyboard #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

πŸ”€ :: (#410) - refactor integrating keyboard #411

wants to merge 10 commits into from

Conversation

@audgns10
Copy link
Member

@audgns10 audgns10 commented Aug 16, 2024

πŸ“Œ κ°œμš”

  • ν•œ 일을 κ°„λ‹¨ν•˜κ²Œ μ μ–΄μ£Όμ„Έμš”.
    • ν‚€λ³΄λ“œκ°€ μ—΄λ¦¬κ±°λ‚˜ λ‹«νž λ•Œ μžλ™μœΌλ‘œ ν¬μ»€μŠ€κ°€ 관리가 될 수 μžˆλ„λ‘ ν•˜λŠ” μ½”λ“œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€

πŸ“Έ κ΅¬ν˜„ ν™”λ©΄

  • μŠ€ν¬λ¦°μƒ·μ΄ ν•„μš”ν•˜λ‹€λ©΄ μ²¨λΆ€ν•΄μ£Όμ„Έμš”.

πŸ“š 레퍼런슀 (λ˜λŠ” μƒˆλ‘œ μ•Œκ²Œ 된 λ‚΄μš©) ν˜Ήμ€ κΆκΈˆν•œ 사항듀

  • μ°Έκ³ ν•  사항이 μžˆλ‹€λ©΄ μ μ–΄μ£Όμ„Έμš”.

@audgns10
♻️ :: Refactor Integrating Keyboard
4542b84
@audgns10
πŸ“ :: Apply Before Commit(Refactor Integrating Keyboard - Custom TextF…
7ebf25a 
…ield Component)
@audgns10
♻️ :: Add isKeyboardOpen Logic
f6889e4
@audgns10
♻️ :: Add Integrating Keyboard Logic
7f9f5ff
@audgns10
Merge branch 'refactor/410-refactor-integrating-keyboard' of https://…
e8501a1 
…github.com/Team-MindWay/Mindway-v2-Android into refactor/410-refactor-integrating-keyboard
@audgns10
πŸ”₯ :: Fire Spacing
80783f2
@audgns10
πŸ”₯ :: Fire Spacing - MindWayTextField(Code Simplify)
0b724b3
@audgns10
Merge branch 'refactor/410-refactor-integrating-keyboard' of https://…
0bec260 
…github.com/Team-MindWay/Mindway-v2-Android into refactor/410-refactor-integrating-keyboard
@audgns10
♻️ :: Apply Component Changed(Add Integrating Keyboard Logic - TextFi…
ff9d6e8 
…eld Component)
@audgns10 audgns10 added 2️⃣ Priortiy: Mediuminvalid μš°μ„ μˆœμœ„ - 쀑 ✨ Type: Feature κΈ°λŠ₯ μΆ”κ°€ πŸ”¨ Type: Refector μ½”λ“œ λ¦¬νŒ©ν† λ§ labels Aug 16, 2024
@audgns10 audgns10 self-assigned this Aug 16, 2024
@audgns10 audgns10 linked an issue Aug 16, 2024 that may be closed by this pull request
Refactor Integrating Keyboard #410
Open
answad
answad reviewed Aug 17, 2024
View reviewed changes
presentation/src/main/java/com/chobo/presentation/view/book/screen/BookAddBookScreen.kt
Comment on lines +59 to +62
val imeInsets = WindowInsets.ime
val imeHeightPx = imeInsets.getBottom(LocalDensity.current)
val imeHeightDp: Dp = with(LocalDensity.current) { imeHeightPx.toDp() }

Copy link
Member

@answad answad Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state으둜 ν‚€λ³΄λ“œ μ—΄λ €μžˆλŠ”μ§€ μ•ˆμ—΄λ €μžˆλŠ”μ§€ λ°˜ν™˜ν•˜λŠ” ν•¨μˆ˜ λ§Œλ“€μ–΄μ„œ util에 λ„£μœΌλ©΄ μ’‹μ„κ±°κ°™μŠ΅λ‹ˆλ‹€

Copy link
Member Author

@audgns10 audgns10 Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희 ν™•μ‹€ν•˜κ²Œ μ‚¬μš©ν•˜λŠ” κ±΄κ°€μš”?

Copy link
Member

@answad answad Aug 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 저희 λ””μžμ΄λ„ˆλΆ„ν•˜κ³  이야기 해봐야 ν• κ±°κ°™μŠ΅λ‹ˆλ‹€

Copy link
Member Author

@audgns10 audgns10 Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러면 일단은 이 pr은 μœ μ§€μ‹œν‚€κ² μŠ΅λ‹ˆλ‹€
λ””μžμ΄λ„ˆλΆ„κ³Ό 이야기가 λλ‚ λ•ŒκΉŒμ§€λŠ”

Copy link
Member

@answad answad Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅

@audgns10 audgns10 changed the title Refactor/410 refactor integrating keyboard πŸ”€ :: (#410) - refactor integrating keyboard Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@answad answad answad left review comments

@minStone-dev minStone-dev Awaiting requested review from minStone-dev

@yeongun130 yeongun130 Awaiting requested review from yeongun130

At least 1 approving review is required to merge this pull request.

Assignees

@audgns10 audgns10

Labels

2️⃣ Priortiy: Mediuminvalid μš°μ„ μˆœμœ„ - 쀑 ✨ Type: Feature κΈ°λŠ₯ μΆ”κ°€ πŸ”¨ Type: Refector μ½”λ“œ λ¦¬νŒ©ν† λ§

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor Integrating Keyboard

3 participants

@audgns10 @answad