-
Notifications
You must be signed in to change notification settings - Fork 0
[REFACTOR/#253] Release 환경 Proguard 설정을 수정합니다. #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the Android app’s build configuration. In the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/build.gradle.kts (1)
62-65: Review Proguard File ReferencesAlthough Proguard optimizations are disabled in the release build, the
proguardFiles(...)configuration still exists in this block. If minification and resource shrinking are no longer needed, consider removing these references to reduce potential confusion and simplify the build configuration. If they are kept for historical reasons or potential future use, please document the rationale.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/build.gradle.kts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
app/build.gradle.kts (2)
28-28: Version Code Bump to 24The version code in the
defaultConfigsection has been updated from 23 to 24 as part of this release. Please ensure that the associated versioning strategy (including versionName changes, if needed) is consistently documented and communicated.
59-60: Disabling Code Minification and Resource Shrinking in ReleaseThe release build configuration now explicitly disables both code minification (
isMinifyEnabled = false) and resource shrinking (isShrinkResources = false). This change directly addresses the issues encountered with Proguard in the release environment. Please verify that this configuration meets the desired trade-offs (e.g., APK size, performance, and security) and that it has been approved by your team.
📌 ISSUE
closed #253
📄 Work Description
✨ PR Point
release 환경에서 기본적으로 proguard설정이 들어가 앱 빌드 시 문제가 생기는 걸 확인 안했습니다ㅠㅠㅠ
📸 ScreenShot/Video
Summary by CodeRabbit