GompeiLib sync (pull)

lib/.github/workflows/approvalautomation.yaml

@@ -28,11 +28,11 @@ jobs:
 
             // Separate bot and human reviews
             const botReviews = reviews
-              .filter(r => r.user.login === '190approvalbot')
+              .filter(r => r.user.login === '190automationbot')
               .sort((a, b) => new Date(b.submitted_at) - new Date(a.submitted_at));
 
             const humanReviews = reviews
-              .filter(r => r.user.login !== '190approvalbot')
+              .filter(r => r.user.login !== '190automationbot')
               .sort((a, b) => new Date(b.submitted_at) - new Date(a.submitted_at));
 
             const latestBotReview = botReviews[0];
@@ -70,16 +70,23 @@ jobs:
 
             } else {
               // Request review from ElliotScher for other authors
-              const alreadyRequested = pr.requested_reviewers.map(r => r.login).includes('ElliotScher');
-              if (!alreadyRequested) {
-                console.log("Requesting review from ElliotScher");
-                await github.rest.pulls.requestReviewers({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  pull_number: prNumber,
-                  reviewers: ['ElliotScher']
-                });
+              if (prAuthor !== 'ElliotScher') {
+                const alreadyRequested = pr.requested_reviewers
+                  .map(r => r.login)
+                  .includes('ElliotScher');
+
+                if (!alreadyRequested) {
+                  console.log("Requesting review from ElliotScher");
+                  await github.rest.pulls.requestReviewers({
+                    owner: context.repo.owner,
+                    repo: context.repo.repo,
+                    pull_number: prNumber,
+                    reviewers: ['ElliotScher']
+                  });
+                } else {
+                  console.log("ElliotScher already requested as reviewer");
+                }
               } else {
-                console.log("ElliotScher already requested as reviewer");
+                console.log("Skipping review request because author is ElliotScher");
               }
             }

lib/.github/workflows/build.yaml

@@ -1,6 +1,9 @@
 name: Build
 
 on:
+  push:
+    branches:
+      - main
   pull_request:
 
 jobs:

lib/.github/workflows/lint.yaml

@@ -1,6 +1,9 @@
 name: Lint
 
 on:
+  push:
+    branches:
+      - main
   pull_request:
 
 jobs:

lib/src/main/java/edu/wpi/team190/gompeilib/subsystems/vision/camera/CameraStaticLimelight.java

@@ -89,7 +89,11 @@ public CameraStaticLimelight(
     LimelightHelpers.setRewindEnabled(name, config.enableRewind());
 
     LimelightHelpers.SetIMUMode(name, 1);
-    LimelightHelpers.SetThrottle(name, 190);
+    if (GompeiLib.isTuning()) {
+      LimelightHelpers.SetThrottle(name, 0);
+    } else {
+      LimelightHelpers.SetIMUMode(name, 190);
+    }
 
     wasEnabled = false;
     enabledTimestamp = Timer.getFPGATimestamp();
@@ -123,9 +127,9 @@ public void periodic() {
         wasEnabled = false;
         LimelightHelpers.SetIMUMode(name, 1);
         if (GompeiLib.isTuning()) {
-          LimelightHelpers.SetThrottle(name, 190);
+          LimelightHelpers.SetThrottle(name, 0);
         } else {
-          LimelightHelpers.SetIMUMode(name, 0);
+          LimelightHelpers.SetIMUMode(name, 190);
         }
       }
     }