Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for teachbooks v0.2.0 #131
base: release
Are you sure you want to change the base?
Prepare for teachbooks v0.2.0 #131
Changes from 4 commits
f6afbfc
22eacbf
a25cdfe
53fdeda
e5426cc
40c9f63
2229dd7
92b026d
50131ee
de6ba9e
b78aa6a
d572a0f
9b82c05
3f77301
ef4b94c
05f0045
b33bd13
fac9554
e1f25a8
55b6862
62ddb34
9b74a25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have never warned people about updates and relevant caching in the past for the other tools (which are no different in this perspective).
Maybe this warning shouldn't be in the manual, but only in the announcement on teachbooks.io. Or we could remove the warning after a week. I think it can be kinda complicated for some users and giving the explicit explanation might do more harm than good on these very-easy-to-implement feature pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'We do not expect it to cause issues with existing books, but if it does, you can use the following in your requirements file:
teachbooks<0.2.0
.' If we really don't expect it, couldn't we just leave this out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I'll adapt this and get back to you once I have a chance to read the stuff in #132