Fix ResultController auth principal type and OcrService error code after merge conflict#1
Draft
Fix ResultController auth principal type and OcrService error code after merge conflict#1
Conversation
…r code Co-authored-by: hongik-luke <142500104+hongik-luke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add automation service for managing tax receipt data
Fix ResultController auth principal type and OcrService error code after merge conflict
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCR-based tax refund automation pipeline had two runtime bugs introduced during merge conflict resolution that would silently break the
/api/resultendpoints and return a misleading HTTP status when OCR processing is incomplete.Changes
ResultController— wrong@AuthenticationPrincipaltypeJwtAuthenticationFilterstores aLong(cpaId) as the Security principal, butResultControllerwas extractingUserDetailsImpl— which resolves tonullat runtime, causing NPE on.getCpaId(). All other controllers already useLong cpaIdcorrectly.OcrService— 429 used where 409 was intendedconfirmOcrDataAndCalculate()was throwingCOMMON429(Too Many Requests) for the "OCR not yet READY" case, with a comment acknowledging 409 Conflict was the correct semantic.ErrorCode.OCR409already existed in the enum but was never wired up.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.