Add roadmap: Orthogonal and spin groups - #255
Conversation
Head branch was pushed to by a user without write access
CBirkbeck
left a comment
There was a problem hiding this comment.
(Claude here, posting on Chris's behalf. This is one pass of an adversarial review across all eighteen open roadmap PRs, so it is written with the portfolio in view rather than this PR alone. Push back freely — Chris will arbitrate anything contested.)
Verdict: request one mathematical correction, and keep the roadmap stacked behind its suppliers.
Correction: dimension-two noncompactness is not proved by Eichler transvections
The roadmap says noncompactness of O(x² − y²)(ℝ) is exhibited by the transvection family of Layer 2C, and Layer 2D suggests using that family for every isotropic form.
For a hyperbolic plane with isotropic vector u, the form is nondegenerate and B(u, u) = 0, so u ∈ u^⊥ and u^⊥ is one-dimensional — that is,
u^⊥ / Ku = 0.
The Eichler-transvection parameter space of Layer 2C is therefore trivial in dimension two, and cannot exhibit noncompactness at all.
Required edit
Split the proof by dimension:
- in dimension two, use the diagonal torus
t ↦ diag(t, t⁻¹)in thexy-model; - in dimension at least three, use the Eichler transvections.
Correct both the Layer 2D proof plan and the worked acceptance example, which currently inherits the same gap.
Dependency blockers
Keep the roadmap stacked behind Reductive Groups, #246, #250, #252 and #254. In particular its Tamagawa-number calculation should consume the final central-isogeny defect formula from #246 rather than restating it.
Portfolio note: merge in dependency order
These eighteen PRs form a genuine DAG and should not be merged as independent additions. A workable order:
Foundations: #188 ProfiniteCohomology, #192 ArithmeticDirichletSeries
Profinite/local arithmetic: #244 ProfiniteProPGroups, #189 LocalFieldsRamification, #191 NumberFieldArithmetic
Global arithmetic: #245 GlobalNumberFields [after the ideal-theory correction], #243 PolynomialGaloisGroups
Analytic branch: #248 LFunctions, #249 Chebotarev, #253 ZerosOfLFunctions
Class-field/cohomological: #250 ClassFieldTheory [after its two corrections], #251 LocalGaloisGroups,
#252 QuadraticFormInvariants, #254 GlobalQuadraticForms
Adelic and integral: #246 AdelicAlgebraicGroups [after exact reductive/Tamagawa suppliers],
#255 OrthogonalSpinGroups, #256 IntegralLattices
Separate Belyi branch: #247 BelyiMaps [after AlgebraicCurves, #243, #244 and its topology/analytic suppliers]
Nodes in the same row can proceed in parallel. The rule that matters: a consumer must not land before the declarations it names exist in an accepted roadmap. Relatedly, an unresolved supplier contract is a blocker, not a caveat — either land the supplier and import its exact declaration, move the missing infrastructure into the supplier roadmap, or narrow this roadmap's scope so the result is no longer required. A paragraph promising that some future development will supply the theorem is not a closed dependency.
|
Addressed the requested changes in
Verification:
I also started |
The README roadmap list and the two issue-template `area` dropdowns are regenerated from the roadmap directories by the sync bot after merge, and the root `TauCetiRoadmap.lean` no longer carries an import list, because `lakefile.toml` globs every module under `TauCetiRoadmap/`. Editing these four files by hand was never required, and made this branch conflict with every other open roadmap pull request. Restoring them to the merge base makes this branch mergeable again; the roadmap is still registered automatically once it merges. Pushed by a maintainer to clear a repository-wide merge conflict, see TauCetiProject#273 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The review asked that removed summits have an exact owner rather than a description. The deferred applications at the end of the roadmap were "Successor A" and "Successor B"; they are now both OrthogonalTamagawaAndLatticeMass, over TauCetiProject#246's four named generic successors AlgebraicGroupStrongApproximation, ArithmeticReductionTheory, TamagawaMeasures and AdelicFourierAnalysis. Every "a future successor" in the README and in Suggested.lean is replaced by that name. One ownership correction: the scope-exclusion paragraph sent the mass formula to IntegralLattices, which no longer owns it either -- it needs the strong approximation and Tamagawa volume that this roadmap and TauCetiProject#246 both exclude. The mass formula and the genus/spinor-genus comparison go to OrthogonalTamagawaAndLatticeMass with the rest. No milestone, declaration or convention changes; the dimension-two acceptance witness diag(t, t-inverse) with u-perp/Ku = 0, and the Eichler transvections in dimension at least three, are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The review's architectural blocker: this roadmap still rested on strong approximation for Spin, a Tamagawa normalization and an orthogonal volume theorem, and the reviewed scopes of TauCetiProject#246 and TauCetiProject#255 export none of them. A prose reference to a removed supplier milestone is not a closed dependency, so the results that need them move out, to one exact owner -- the successor roadmap OrthogonalTamagawaAndLatticeMass that TauCetiProject#255 and TauCetiProject#246 name from their side. Moved: 4D Eichler's theorem and the rank->=3 half of 4E; 7B the adelic decomposition; the Tamagawa-volume half of 7C; 7F the volume theorem; 7H the Conway-Sloane formula; 7I rank-16 completeness. Kept, because the successor consumes them rather than supplying them: 4A class and genus sets, 4B the stabilizer dictionary, 4C spinor genera and the proper spinor genus class group, 4F, 4G, rank 2 of 4E through B2/B5, 7A the two masses with m+ = 2m, 7C's local density at odd p, 7D Cho's dyadic density, 7E the archimedean factor, and 7G the low-rank values. None of those uses an adelic volume, so the split leaves no gap between the two documents. Suggested.lean drops #check OrthogonalSpinGroups.strongApproximation_finiteAdelicSpin, a name TauCetiProject#255 does not export and has said only the successor may, and checks four names TauCetiProject#255 does export and this roadmap does consume instead. Layer 7's title, the scope section, the supplier tables, the ordering section, the API checklists, the hard-theorem table and the worked examples all follow. No convention or corrected statement changes: the invertible-proper-ideal carrier for Pic and NarrowPic, the separate ideal class monoid, the square-discriminant branch, formTwist against carrier dilation, the half-norm discriminant form in Q/Z, the Nikulin nondegeneracy hypothesis and the D8+ = E8 artifact are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
🤖 Claude Opus 5, on David Roe's behalf. Addressed the remaining scope/metadata mismatch in 1. Every deferred summit now has an exact owner. The two sections at the end of the README were "Successor A" and "Successor B", which is a description rather than an owner. They are now both 2. An ownership error found while doing it. The scope-exclusion paragraph sent the mass formula to 3. The PR description no longer advertises removed material. It previously claimed the Spin application of strong approximation and 4. Direct dependencies derived from the imports. 5. The dimension-two acceptance witness is unchanged. Dimension two still uses the unbounded diagonal torus Verification. In a dependency-complete local stack (every open roadmap branch merged in) Merge order. This branch's GitHub |
Brings in the merged ArithmeticDirichletSeries (TauCetiProject#192) and the generated roadmap-index sync, so this branch builds against the current main rather than the fork point. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CBirkbeck
left a comment
There was a problem hiding this comment.
Verdict
Request changes.
The convention work is excellent, especially the reflection coefficient and the distinction between reverse and Mathlib's star. The main remaining problem is that the roadmap relies on Mathlib's lipschitzGroup/pinGroup/spinGroup carriers before proving that those carriers have the general-field interpretation needed for the claimed exact sequence.
1. Prove the comparison with Mathlib's actual lipschitzGroup
Mathlib's lipschitzGroup is defined through a closure construction, and its own documentation records that equivalence with the usual “twisted conjugation preserves V” Clifford group is not fully available in general.
The roadmap then uses:
- scalar units as elements of
lipschitzGroup; - all products of anisotropic vectors;
- surjectivity to
O(Q); - kernel equal to scalar units.
Each inclusion should be a named theorem against Mathlib's actual carrier. It is not enough that these statements are classical for the usual Clifford group.
In particular, prove:
scalarUnits_mem_lipschitzGroup
vectorUnit_mem_lipschitzGroup
product_vectorUnits_mem_lipschitzGroup
ker_vectorRepresentation_eq_scalarUnitsunder the exact finite-dimensional/nondegenerate/positive-dimension hypotheses.
2. Reconcile the two norm conditions before using spinGroup
Mathlib's Pin carrier is cut out using the star-unitary condition, while this roadmap's Clifford norm is
[
N(g)=\operatorname{reverse}(g)g.
]
The roadmap correctly observes that these differ by a sign on odd degree. The exact sequence nevertheless uses Mathlib's spinGroup.
A full comparison theorem is needed:
- on even homogeneous elements, star norm equals reverse norm;
spinGroupis exactly the even Lipschitz elements with reverse norm one;- multiplying a Lipschitz lift by a scalar of square inverse produces a Spin lift precisely when the spinor norm vanishes.
These are the heart of im(Spin(K))=ker θ; they should be explicit declarations rather than consequences left inside the proof.
3. The low-rank twisted groups lack carriers
The roadmap states over a general field:
Spin₅ ≅ Sp(C₀,σ);Spin₆ ≅ SU(C₀,σ);- split and nonsplit forms in dimension four.
But it simultaneously excludes developing symplectic and unitary groups as a subject, and no supplier is named for the groups of a central simple algebra with involution.
The roadmap must either:
- define the exact point-group carriers
Sp(A,σ)andSU(A,σ)needed here, with their functoriality; or - move the twisted low-rank identifications to a successor which owns those carriers.
An isomorphism to an unnamed group is not a theorem specification.
4. Local spinor-norm image statements must split the real cases
Any local surjectivity theorem must distinguish:
- nonarchimedean local fields;
- real indefinite forms;
- real positive or negative definite forms.
For a positive-definite real form, all reflection norms are positive and the image in
R×/(R×)² is trivial, not all square classes. State the local table by field and signature.
5. The adelic square-class restricted product needs openness of the reference images
The codomain uses θ_p(U_p^{SO}) as the reference subgroup. To obtain the intended topological restricted product, prove that these images are open, and identify them at almost all primes. Continuity alone does not make the image of a compact open subgroup open.
This local image computation is also what the lattice spinor-genus roadmap consumes.
6. Keep successor material out of the normative current build
The long strong-approximation/Tamagawa sections are careful, but they dominate the current README despite not being milestones. A short exact consumer contract is enough. The detailed future proof plans belong in the successor roadmap.
What is good
The reflection normalization, Cartan–Dieudonné use, spinor norm via reflections, warning that Spin(K)→SO(K) need not be onto, non-discreteness in finite adeles, and separation of mass/strong approximation from the current scope are all excellent.
Recommendation
Close the comparison with Mathlib's carriers, pin the reverse/star Spin theorem, supply or defer the low-rank twisted group carriers, and state the complete local image table.
…ections The roadmap used Mathlib's `lipschitzGroup`, `pinGroup` and `spinGroup` while quoting facts that hold for the classical Clifford group, which Mathlib's own docstring says it does not know to be the same object. It also stated the low-rank identifications against groups nothing defines, gave one local spinor-norm image for the real place, and left the adelic codomain's reference subgroups unexamined. Against Mathlib's actual `lipschitzGroup`, which is a `Subgroup.closure` of the invertible vectors: `vectorUnit` with `vectorUnit_mem_lipschitzGroup` and `vectorUnit_inv`, `product_vectorUnits_mem_lipschitzGroup`, the characterization `mem_lipschitzGroup_iff_exists_list`, and `scalarUnits_mem_lipschitzGroup`, each with the finite-dimensionality, nondegeneracy and positive-dimension hypotheses its proof uses. `scalarUnits` is now data — a codomain restriction — rather than a `sorry`-bodied definition, so `ker_vectorRepresentation_eq_scalarUnits` is an equation between two visible subgroups instead of two opaque ones. The `reverse` norm and Mathlib's `star`-unitary Pin and Spin are reconciled by three named theorems rather than inside a proof: `star_mul_self_eq_reverse_mul_self_of_mem_even`, its sharpening `star_mul_self_eq_neg_one_pow_reverse_mul_self`, `mem_spinGroup_iff_cliffordNorm_eq_one`, together with the bridge `spinorNorm_vectorRepresentation` and the rescaling criterion `exists_scalarUnits_mul_mem_spinGroup_iff`. Those five are what make `range_spinToSpecialOrthogonal` a theorem about `spinGroup`. The low-rank isomorphisms get a carrier, `evenUnitaryGroup`, which is `U(C₀, σ)` for the canonical involution `σ = reverse`; `range_spinGroup_toUnits` reads Mathlib's `spinGroup` as `lipschitzGroup ⊓ evenUnitaryGroup`, and `evenUnitaryGroup_le_lipschitzGroup` gives `Spin(Q) = U(C₀, σ)` in dimensions one to five, which covers the quaternionic, split/nonsplit quaternary and symplectic cases. Dimension zero and dimension six are rejection tests: at zero the unitary group is `μ₂` while the closure is trivial, and at six the inclusion is strict because `Spin(Q)` is the reduced-norm-one subgroup. The reduced norm has no owner anywhere, so `Spin ≅ SU(C₀, σ)` moves to the named successor `AlgebrasWithInvolution`, and 1F states only what is provable here. 2F is now a table by field, dimension and signature, with a named theorem per row and the general lemma `spinorNorm_range_orthogonal_eq_sup` generating the `O` column from the `SO` column. A positive definite real form has **trivial** image on `O` as well as on `SO`, a negative definite one has all of `ℝˣ/(ℝˣ)²` on `O`, and an anisotropic binary `p`-adic form has index two on `SO` and, when it represents one, on `O` as well. For the adelic codomain, `isOpen_localSpinorNormImage` proves the reference subgroups open — through `discreteTopology_localSquareClasses`, since continuity of `θ_p` gives compactness of the image and not openness — and `eventually_localSpinorNormImage_eq_unitSquareClasses` identifies them with `unitSquareClasses` at almost every prime for the integral family `integralOrthogonalSubgroup` of a basis, which is also `eventually_mem_orth` discharged. `exists_localSpinorNormImage_ne_unitSquareClasses` records that the value, unlike the openness, is a property of the family. The strong-approximation and Tamagawa material is now one short consumer contract for `OrthogonalTamagawaAndLatticeMass` instead of two long sections, 3A is a pointer rather than an eight-item plan, and the Mathlib Haar survey is gone since no milestone consumes it. Follows the supplier rename: `AdelicAlgebraicGroups` is `RestrictedProducts`, `FiniteAdelicPoints`/`AdelicPoints` are `RestrictedProductGroup`/`RestrictedProductGroupWithFactor`, the away-`S` groups use the supplier's own `RestrictedProductGroupAway` and `restrictAway`, and the two componentwise maps use `restrictedProductMapOfForall`, the everywhere-preserving constructor, since only it carries `integralSubgroup` into `integralSubgroup`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
🤖 Claude Opus 5, on David Roe's behalf. Addressed in 1. The comparison with Mathlib's carrier — checked against Mathlib first. 2. The two norm conditions are three declarations now: equality on even elements, the sign sharpening, and 3. Low-rank carriers. 4. The local table by field and signature, one named theorem per row. Your correctness point is Lean-stated: 5. Openness proved; the identification narrowed, deliberately. 6. Successor material cut from ~135 lines to a 40-line consumer contract; the Mathlib Haar survey is gone since no milestone consumes it. #246's rename is propagated: module, namespace, both carrier renames, the away- Verification. The whole portfolio was built in one dependency-complete checkout — all sixteen open roadmap branches merged together, at their final state — and is green: |
CBirkbeck
left a comment
There was a problem hiding this comment.
Current head: 77f35a7da26b28a9d8fba79cb1cf913d80f8882e
Verdict
Approve after the local-field and quadratic-form suppliers land.
The current roadmap has repaired the main carrier problem: it now proves comparison theorems for Mathlib's actual closure-defined Lipschitz group instead of silently replacing it by the classical Clifford group.
What I checked
The Clifford-algebra conventions are now pinned:
starandreverseare compared on homogeneous and even elements;- the Clifford norm used in the spinor norm is named;
- the vector representation is compared with the classical conjugation action;
- every orthogonal transformation is represented by a Lipschitz element;
- rescaling an even lift into
spinGroupis characterized by the square class of its norm.
This closes the exactness statement
$$
\mu_2\longrightarrow \operatorname{Spin}(Q)
\longrightarrow \operatorname{SO}(Q)
\xrightarrow{\theta} K^\times/(K^\times)^2,
$$
including the dimension-zero exception and the fact that the right-hand map need not be surjective.
The low-rank forms are no longer stated only in the split case. The roadmap names the even Clifford algebra with involution and distinguishes:
- the quaternion norm-one group in dimension three;
- split and nonsplit discriminant algebra in dimension four;
- symplectic involutions in dimension five;
- the unitary/reduced-norm distinction beginning in dimension six.
The topological layer also has the right hypotheses:
- the canonical module topology rather than a chosen-basis topology;
- separation, local compactness and openness of square classes stated separately;
- closedness and local compactness of the point groups;
- an explicit Clifford lift of the Eichler transvections;
- the correct compactness criteria over
$\mathbf R$ and$\mathbf Q_p$ ; - continuity of the spinor norm proved through its open kernel.
The adelic layer consumes the generic restricted-product roadmap and does not take ownership of strong approximation or Tamagawa measures. Those are assigned to named successors.
I do not see a remaining formula error or an unassigned prerequisite.
Summary
This roadmap develops the arithmetic of the orthogonal and spin groups of a finite-dimensional
nondegenerate quadratic space over a field of characteristic not two, and their specialization
to the local and finite-adelic setting.
Suggested.leancarries 109 declarations thatelaborate against the pinned Mathlib and the three suppliers above:
orthogonalGroup,specialOrthogonalGroup, the determinantcharacter and the index-two subgroup, and
reflectionwith its determinant, conjugation andmembership lemmas;
cliffordNormandstarNormkept apart,scalarUnits, thevector representation with its surjectivity and its kernel, and the dimension-zero rejection
test that shows why the kernel theorem needs positive dimension;
spinorNormand its value on a reflection,spinToSpecialOrthogonalwith
muTwoToSpin, and the kernel and range of that map;O/SO,local compactness, and openness of the spinor-norm kernel;
transvectionwith its additivity, conjugation and spinor norm,the canonical Clifford lifts
transvectionLift, and the homomorphismtransvectionLiftHomon
u^⊥/Ku;ℚ_pand toℝ,OrthogonalCompactOpenswith the eventual-integrality data, local spinor-norm images, and the finite, away-
Sandfull adelic groups obtained by specializing Add roadmap: restricted products and rational diagonals #246's generic restricted-product API rather
than rebuilding it, with the rational diagonals, the discreteness statements, and
adelicSpinorNormwithadelicSpinorKernel.What is not a milestone here, and who owns it
Not current milestones, and not claimed by this PR: generic algebraic-group strong
approximation; reduction theory; Tamagawa measures and numbers; central-isogeny volume ratios;
and the orthogonal computation
τ(SO_Q) = 2. #246 deliberately exports none of the genericmachinery they need, so a promise here would not be a closed dependency.
Each has one exact owner. #246 names four generic successors —
AlgebraicGroupStrongApproximation,ArithmeticReductionTheory,TamagawaMeasuresandAdelicFourierAnalysis— and the orthogonal specialization on top of them is the successorroadmap
OrthogonalTamagawaAndLatticeMass. That one owns both of the deferred applicationsections at the end of the README: the Spin application of strong approximation with its
spinor-kernel consequence, and the Tamagawa/volume computation with
τ(SO_Q) = 2and itslow-dimensional exceptions. It also owns the two results #256 has moved out of the lattice
roadmap for the same reason: the genus/spinor-genus comparison in rank
≥ 3and theSmith–Minkowski–Siegel mass formula. The scope-exclusion paragraph is corrected accordingly —
it previously sent the mass formula to
IntegralLattices, which cannot own it either.Everything those applications need from this roadmap is already exported here: the three point
groups, the transvections and their canonical Spin lifts, the local spinor norms, and the
adelic specialization. That is why Layers 0–3 expose all of them.
The dimension-two acceptance witness, preserved
Unchanged by this revision. Noncompactness in dimension two uses the unbounded diagonal torus
t ↦ diag(t, t⁻¹)in thexymodel, and the acceptance proof records thatu^⊥/Ku = 0there,so the Eichler transvection family cannot serve as the witness. In dimension at least three the
witness is a nontrivial Eichler transvection family. The two cases are separate on purpose.
Human review priorities
scalarUnits, the positive-dimension kernel theorem, and the zero-dimensional rejection case;OrthogonalTamagawaAndLatticeMassis the right single owner for the strongapproximation, Tamagawa and mass-formula results that Add roadmap: restricted products and rational diagonals #246, Add roadmap: Orthogonal and spin groups #255 and Expand roadmap: Integral quadratic forms and lattices #256 all exclude.
Port history
A clean port of roed-math/TauCetiRoadmap#12,
rebased onto upstream
main. Generic restricted-product, Haar/Tamagawa, reduction-theory andstrong-approximation material moved to #246 and then, when #246 narrowed, to its named
successors. The reviewed Clifford, spinor, transvection, normalization and low-dimensional
exception conventions stayed here. The non-normative
PROVENANCE.mdis omitted; the detailedmigration ledger remains private.
Validation
lake build TauCetiRoadmap.OrthogonalSpinGroups.Suggested— passesgit diff --check— passespython3 .github/scripts/check_roadmap_areas.py— reportsOrthogonalSpinGroupsmissing fromthe two issue-template dropdowns and the README list, which is deliberate since
#273: the sync bot regenerates
those four files after merge, and this branch leaves them at the merge base.
The branch keeps the direct imports of its three open suppliers, so the GitHub Actions
buildcheck stays dependency-blocked until they merge, and goes green once they do and the branch is
updated from
main.AI and external formalization disclosure
The roadmap and this revision were prepared with substantial assistance from Claude Fable and
Opus 5, and GPT-5.6 Codex and Pro, under the author's direction. A detailed migration and
coordination ledger is maintained privately. No external source code was copied into this
roadmap.