Skip to content

Dockerfile added #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Dockerfile added #20

wants to merge 9 commits into from

Conversation

ggarbereder
Copy link
Contributor

No description provided.

Gerrit Garbereder and others added 5 commits June 24, 2023 19:25
Copy link
Member

@dhebbeker dhebbeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perquisite installation procedure for GitHub is independently defined (in .github/workflows/build.yml) of the procedure for Docker (Dockerfile). It would be nice, if it would be specified only once (DRY).

Powershell
```Powershell
docker build -t task-tracker-systems/task-tracker-app:1 .
docker run --rm -v ${PWD}:/dev/mnt task-tracker-systems/task-tracker-app:1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the output of the build? Executing this line, the output ends with

5 actionable tasks: 4 executed, 1 up-to-date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be in the build directory on the host, do you find it there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'host' is the system which hosts Docker?

After executing this (and the previous) line I don't have a ./build/ directory in the root directory. But there are 31 nested build directories.

Is the output to be executed by the user, this file?

./Task-Tracker-CLI/build/scripts/Task-Tracker-CLI

dhebbeker and others added 3 commits June 27, 2023 22:01
This way it doesn't need to be set individually.
Setting the file mode individually leads to a modified workspace.
…file-mode

Set file modes of executeables accordingly.
Generic shell name

Co-authored-by: David Hebbeker <[email protected]>
@ggarbereder ggarbereder marked this pull request as ready for review July 1, 2023 08:53
Powershell
```Powershell
docker build -t task-tracker-systems/task-tracker-app:1 .
docker run --rm -v ${PWD}:/dev/mnt task-tracker-systems/task-tracker-app:1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'host' is the system which hosts Docker?

After executing this (and the previous) line I don't have a ./build/ directory in the root directory. But there are 31 nested build directories.

Is the output to be executed by the user, this file?

./Task-Tracker-CLI/build/scripts/Task-Tracker-CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants