-
Notifications
You must be signed in to change notification settings - Fork 0
Dockerfile added #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dockerfile added #20
Conversation
Add first basic docker file to compile the project. The image is not good yet, it does not cache enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The perquisite installation procedure for GitHub is independently defined (in .github/workflows/build.yml
) of the procedure for Docker (Dockerfile
). It would be nice, if it would be specified only once (DRY).
Powershell | ||
```Powershell | ||
docker build -t task-tracker-systems/task-tracker-app:1 . | ||
docker run --rm -v ${PWD}:/dev/mnt task-tracker-systems/task-tracker-app:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the output of the build? Executing this line, the output ends with
5 actionable tasks: 4 executed, 1 up-to-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be in the build
directory on the host, do you find it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'host' is the system which hosts Docker?
After executing this (and the previous) line I don't have a ./build/
directory in the root directory. But there are 31 nested build
directories.
Is the output to be executed by the user, this file?
./Task-Tracker-CLI/build/scripts/Task-Tracker-CLI
This way it doesn't need to be set individually. Setting the file mode individually leads to a modified workspace.
…file-mode Set file modes of executeables accordingly.
Generic shell name Co-authored-by: David Hebbeker <[email protected]>
Powershell | ||
```Powershell | ||
docker build -t task-tracker-systems/task-tracker-app:1 . | ||
docker run --rm -v ${PWD}:/dev/mnt task-tracker-systems/task-tracker-app:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'host' is the system which hosts Docker?
After executing this (and the previous) line I don't have a ./build/
directory in the root directory. But there are 31 nested build
directories.
Is the output to be executed by the user, this file?
./Task-Tracker-CLI/build/scripts/Task-Tracker-CLI
No description provided.